Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-27 Thread Peter Maydell
On 27 October 2014 15:05, Peter Maydell wrote: > On 27 October 2014 14:39, Paolo Bonzini wrote: >> What about: >> >> /* SIGINT cannot be handled via signalfd, so that ^C can be used >> * to interrupt QEMU when it is being run under gdb. SIGHUP and >> * SIGTERM are also handled asyn

Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-27 Thread Peter Maydell
On 27 October 2014 14:39, Paolo Bonzini wrote: > > > On 10/27/2014 03:18 PM, Peter Maydell wrote: >> On 26 October 2014 09:32, Jan Kiszka wrote: >>> From: Jan Kiszka >>> >>> This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks >>> debuggability of qemu. >>> >>> Signed-off-by:

Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-27 Thread Paolo Bonzini
On 10/27/2014 03:18 PM, Peter Maydell wrote: > On 26 October 2014 09:32, Jan Kiszka wrote: >> From: Jan Kiszka >> >> This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks >> debuggability of qemu. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Feel free to apply this before or

Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-27 Thread Peter Maydell
On 26 October 2014 09:32, Jan Kiszka wrote: > From: Jan Kiszka > > This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks > debuggability of qemu. > > Signed-off-by: Jan Kiszka > --- > > Feel free to apply this before or after "Make qemu_shutdown_requested > signal-safe". > > m

Re: [Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-26 Thread Gonglei
On 2014/10/26 17:32, Jan Kiszka wrote: > From: Jan Kiszka > > This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks > debuggability of qemu. > > Signed-off-by: Jan Kiszka > --- > Thanks, please add my 'Reported-by' tag and Reviewed-by: Gonglei > Feel free to apply this b

[Qemu-devel] [PATCH] Revert "main-loop.c: Handle SIGINT, SIGHUP and SIGTERM, synchronously"

2014-10-26 Thread Jan Kiszka
From: Jan Kiszka This reverts commit 15124e142034d21341ec9f1a304a1dc5a6c25681. It breaks debuggability of qemu. Signed-off-by: Jan Kiszka --- Feel free to apply this before or after "Make qemu_shutdown_requested signal-safe". main-loop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/