Re: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-11 Thread Paolo Bonzini
On 10/10/2017 20:32, Martin Schrodt wrote: > These 3 here are only paaudio.c > > - Remove PA reader/writer threads from paaudio.c, and do IO from the > audio timer directly. > - Expose new configurable settings, such as TLENGTH and FRAGSIZE, plus > settings to > enable PA_STREAM_ADJUST_LATENCY f

Re: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread Gerd Hoffmann
On Tue, 2017-10-10 at 19:12 +0200, Martin Schrodt wrote: > Please see > > https://www.reddit.com/r/VFIO/comments/74vokw/improved_pulse_audio_dr > iver_for_qemu/ > > for motivation, and more coverage. > > Changes: > > - Remove PA reader/writer threads from paaudio.c, and do IO from the > audio t

Re: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171010174538.25074-1-q...@martin.schrodt.org Subject: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device. === TEST SCRIPT BEGIN === #!/bin

Re: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171010174403.24660-1-mar...@schrodt.org Subject: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171010171218.14298-1-mar...@schrodt.org Subject: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device. === TEST SCRIPT BEGIN === #!/bin/bash

Re: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread Martin Schrodt
On 10/10/2017 08:18 PM, Eric Blake wrote: > That's a lot of changes to be slamming in one patch. Any chance you can > split it into a series of smaller patches that are easier to review > individually? Perhaps one patch per item in your bulleted list is a > good start for subdividing this into s

Re: [Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread Eric Blake
On 10/10/2017 12:44 PM, Martin Schrodt wrote: > Please see > > https://www.reddit.com/r/VFIO/comments/74vokw/improved_pulse_audio_driver_for_qemu/ > > for motivation, and more coverage. > > Changes: > > - Remove PA reader/writer threads from paaudio.c, and do IO from the audio > timer directly

[Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread Martin Schrodt
Please see https://www.reddit.com/r/VFIO/comments/74vokw/improved_pulse_audio_driver_for_qemu/ for motivation, and more coverage. Changes: - Remove PA reader/writer threads from paaudio.c, and do IO from the audio timer directly. - Add 1 millisecond timers which interface with the HDA device,

[Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread qemu
From: Martin Schrodt Please see https://www.reddit.com/r/VFIO/comments/74vokw/improved_pulse_audio_driver_for_qemu/ for motivation, and more coverage. Changes: - Remove PA reader/writer threads from paaudio.c, and do IO from the audio timer directly. - Add 1 millisecond timers which interfac

[Qemu-devel] [PATCH] Several fixes for the Pulse Audio driver, and the HDA device.

2017-10-10 Thread Martin Schrodt
Please see https://www.reddit.com/r/VFIO/comments/74vokw/improved_pulse_audio_driver_for_qemu/ for motivation, and more coverage. Changes: - Remove PA reader/writer threads from paaudio.c, and do IO from the audio timer directly. - Add 1 millisecond timers which interface with the HDA device,