Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-06-10 Thread Daniel Gutson
El 10/6/2015 7:45, "Peter Maydell" escribió: > > On 10 June 2015 at 10:58, Liviu Ionescu wrote: > > > >> On 29 May 2015, at 22:16, Martin Galvan < martin.gal...@tallertechnologies.com> wrote: > >> > >> > >> ... I think Peter M is the maintainer for Target-ARM. > >> > >> Peter, is this OK to commi

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-06-10 Thread Peter Maydell
On 10 June 2015 at 11:49, Daniel Gutson wrote: > El 10/6/2015 7:45, "Peter Maydell" escribió: >> No; as Peter C suggested, Martin split it into two patches. >> Those patches then got code review, but I don't think Martin >> has sent out a revised series yet. > > Aurelio is the primary author of t

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-06-10 Thread Peter Maydell
On 10 June 2015 at 10:58, Liviu Ionescu wrote: > >> On 29 May 2015, at 22:16, Martin Galvan >> wrote: >> >> >> ... I think Peter M is the maintainer for Target-ARM. >> >> Peter, is this OK to commit? > > was this patch accepted? No; as Peter C suggested, Martin split it into two patches. Those

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-06-10 Thread Liviu Ionescu
> On 29 May 2015, at 22:16, Martin Galvan > wrote: > > > ... I think Peter M is the maintainer for Target-ARM. > > Peter, is this OK to commit? was this patch accepted? if so, where can I get it from? regards, Liviu

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-30 Thread Peter Crosthwaite
On Sat, May 30, 2015 at 3:08 PM, aurelio remonda wrote: >>> if (op < 4) { >>> /* Saturating add/subtract. */ >>> +if (!(arm_dc_feature(s, ARM_FEATURE_THUMB_DSP))){ >>> +/* qsub, qadd, qdadd, qdsub are DSP instructions. */ >>> +

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-30 Thread aurelio remonda
>> if (op < 4) { >> /* Saturating add/subtract. */ >> +if (!(arm_dc_feature(s, ARM_FEATURE_THUMB_DSP))){ >> +/* qsub, qadd, qdadd, qdsub are DSP instructions. */ >> +goto illegal_op; >> +} >>

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-30 Thread Peter Crosthwaite
On Thu, May 28, 2015 at 2:09 PM, Aurelio C. Remonda wrote: > This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, > the main differences being the DSP instructions and an optional FPU. > The DSP instructions are already implemented in Qemu, as the A and R profiles > use them.

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 20:16, Martin Galvan wrote: > On Fri, May 29, 2015 at 4:15 PM, Liviu Ionescu wrote: >> this is fine with me. >> >> unfortunately I cannot review your patch, since I have not enough experience >> with that part of qemu. > > I think Peter M is the maintainer for Target-ARM. > > P

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-29 Thread Martin Galvan
On Fri, May 29, 2015 at 4:15 PM, Liviu Ionescu wrote: > this is fine with me. > > unfortunately I cannot review your patch, since I have not enough experience > with that part of qemu. I think Peter M is the maintainer for Target-ARM. Peter, is this OK to commit? -- Martin Galvan Software

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-29 Thread Liviu Ionescu
> On 29 May 2015, at 15:55, aurelio remonda wrote: > > 2015-05-28 18:22 GMT-03:00 Liviu Ionescu : >>> On 29 May 2015, at 00:09, Aurelio C. Remonda >>> wrote: >>> The optional FPU in the M4 could be added in the future as a "Cortex-M4F" >>> CPU. >> >> in my implementation I had a single name

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 13:55, aurelio remonda wrote > Perhaps we could commit this now and add the VFP in the future? That's how we've generally worked, yes -- if you just ask for a "Cortex-A9" or whatever you get the maximum set of features that CPU can support (so always Neon & VFP even if some A9 h

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-29 Thread aurelio remonda
2015-05-28 18:22 GMT-03:00 Liviu Ionescu : > > On 29 May 2015, at 00:09, Aurelio C. Remonda > > wrote: > > The optional FPU in the M4 could be added in the future as a "Cortex-M4F" > > CPU. > > in my implementation I had a single name ("cortex-m4") and some flags, but a > separate name is proba

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-28 Thread Peter Maydell
On 28 May 2015 at 22:22, Liviu Ionescu wrote: > >> On 29 May 2015, at 00:09, Aurelio C. Remonda >> wrote: >> All we'd have to do is add the ARM_FEATURE_VFP4 to the initfn. > > if it is that simple, why don't we add it in for now? It's not -- the FPU needs support in the exception handling (lazy

Re: [Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-28 Thread Liviu Ionescu
> On 29 May 2015, at 00:09, Aurelio C. Remonda wrote: > > This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, > the main differences being the DSP instructions and an optional FPU. > The DSP instructions are already implemented in Qemu, as the A and R profiles > use them.

[Qemu-devel] [PATCH] Target-arm: Add the Cortex-M4 CPU

2015-05-28 Thread Aurelio C. Remonda
This patch adds the Cortex-M4 CPU. The M4 is basically the same as the M3, the main differences being the DSP instructions and an optional FPU. The DSP instructions are already implemented in Qemu, as the A and R profiles use them. I created an ARM_FEATURE_THUMB_DSP to be added to any non-M thumb2