On Thu, May 8, 2014 at 10:02 AM, Peter Maydell wrote:
>>> total: 0 errors, 0 warnings, 79 lines checked
>>>
>>> /tmp/a has no obvious style problems and is ready for submission.
>>> Check 500, Bad 52
>>
>> How does your new checkpatch compare to our current one?
>
> Yes; we do sometimes let checkp
On Wed, May 7, 2014 at 5:16 PM, Hani Benhabiles wrote:
> FWIW, this new version doesn't trigger a false positive I was having with
> patches 05-07 in [1].
>
> However, from a quick test for this patch on a couple of patches, I am getting
> warnings like this: "WARNING: braces {} are not necessary
On 8 May 2014 14:59, Markus Armbruster wrote:
> Don Slutz writes:
>> I have used to following to see how a new version compares:
>>
>>
>> k=500;i=0;j=0;for sha in $(git log --no-merges --format=format:"%h"
>> -$k);do let i=$i+1; git show $sha >/tmp/a; clear;echo $i;head -20
>> /tmp/a; ./scripts/c
Don Slutz writes:
> On 05/06/14 14:16, Mike Day wrote:
>> This updates scripts/checkpatch.pl to version 0.32. Also,
>> forward-ported the QEMU checks for no tabs and correct capitalization
>> of "QEMU." Finally, make --no-tree the default option since this will
>> be used with Qemu.
>>
>> Signed-
On 05/06/14 14:16, Mike Day wrote:
This updates scripts/checkpatch.pl to version 0.32. Also,
forward-ported the QEMU checks for no tabs and correct capitalization
of "QEMU." Finally, make --no-tree the default option since this will
be used with Qemu.
Signed-off-by: Mike Day
---
Notes: This is
On Tue, May 06, 2014 at 07:28:35PM +0100, Peter Maydell wrote:
> On 6 May 2014 19:16, Mike Day wrote:
> > This updates scripts/checkpatch.pl to version 0.32. Also,
> > forward-ported the QEMU checks for no tabs and correct capitalization
> > of "QEMU." Finally, make --no-tree the default option si
On 6 May 2014 19:59, Mike Day wrote:
> On Tue, May 6, 2014 at 2:28 PM, Peter Maydell
> wrote:
>> A couple of ideas about how we could approach this:
>> (1) make a commit which is simply copying the kernel's 0.32
>> into our repo; then follow that with a series of commits which
>> re
On Tue, May 6, 2014 at 2:28 PM, Peter Maydell wrote:
> I think this is going to be difficult to review, to say the least.
>
> Where does your patch come from? Is the kernel's checkpatch.pl
> just a single commit between 0.31 and 0.32 (surely not) or
> a series of fixes?
Yes, this is today's versi
On 6 May 2014 19:16, Mike Day wrote:
> This updates scripts/checkpatch.pl to version 0.32. Also,
> forward-ported the QEMU checks for no tabs and correct capitalization
> of "QEMU." Finally, make --no-tree the default option since this will
> be used with Qemu.
>
> Signed-off-by: Mike Day
> ---
>
