Re: [Qemu-devel] [PATCH] Virt: ACPI: fix qemu assert due to re-assigned table data address

2017-12-26 Thread Andrew Jones
On Tue, Dec 26, 2017 at 07:54:15PM +0800, Shannon Zhao wrote: > > > On 2017/12/26 19:48, Andrew Jones wrote: > > On Fri, Dec 22, 2017 at 02:52:47PM +0800, Shannon Zhao wrote: > >> acpi_data_push uses g_array_set_size to resize the memory size. If there > >> is no > >> enough contiguous memory,

Re: [Qemu-devel] [PATCH] Virt: ACPI: fix qemu assert due to re-assigned table data address

2017-12-26 Thread Shannon Zhao
On 2017/12/26 19:48, Andrew Jones wrote: > On Fri, Dec 22, 2017 at 02:52:47PM +0800, Shannon Zhao wrote: >> acpi_data_push uses g_array_set_size to resize the memory size. If there is >> no >> enough contiguous memory, the address will be changed. If we use the old >> value, >> it will assert.

Re: [Qemu-devel] [PATCH] Virt: ACPI: fix qemu assert due to re-assigned table data address

2017-12-26 Thread Andrew Jones
On Fri, Dec 22, 2017 at 02:52:47PM +0800, Shannon Zhao wrote: > acpi_data_push uses g_array_set_size to resize the memory size. If there is no > enough contiguous memory, the address will be changed. If we use the old > value, > it will assert. > qemu-kvm: hw/acpi/bios-linker-loader.c:214:

[Qemu-devel] [PATCH] Virt: ACPI: fix qemu assert due to re-assigned table data address

2017-12-21 Thread Shannon Zhao
acpi_data_push uses g_array_set_size to resize the memory size. If there is no enough contiguous memory, the address will be changed. If we use the old value, it will assert. qemu-kvm: hw/acpi/bios-linker-loader.c:214: bios_linker_loader_add_checksum: Assertion `start_offset < file->blob->len'