Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Dan Williams
>> > Good to know, thanks. > > I have made a big mistake. I was comparing the resulting SSDT of this patch > to an SSDT > Generated by a much older version of kvm/qemu. The latest kvm/qemu upstream > builds > the SSDT with the operation region contained inside of methods. This should > resolve

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Schmauss, Erik
> -Original Message- > From: Igor Mammedov [mailto:imamm...@redhat.com] > Sent: Wednesday, April 25, 2018 8:32 AM > To: Michael S. Tsirkin > Cc: Schmauss, Erik ; qemu-devel@nongnu.org; Xiao > Guangrong ; Williams,

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Igor Mammedov
On Wed, 25 Apr 2018 17:17:04 +0300 "Michael S. Tsirkin" wrote: > On Wed, Apr 25, 2018 at 03:49:38PM +0200, Igor Mammedov wrote: > > On Tue, 24 Apr 2018 21:06:37 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Apr 24, 2018 at 05:47:58PM +,

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Michael S. Tsirkin
On Wed, Apr 25, 2018 at 03:49:38PM +0200, Igor Mammedov wrote: > On Tue, 24 Apr 2018 21:06:37 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 24, 2018 at 05:47:58PM +, Schmauss, Erik wrote: > > > > > > > > > > -Original Message- > > > > From: Michael S.

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Igor Mammedov
On Wed, 25 Apr 2018 15:49:38 +0200 Igor Mammedov wrote: > On Tue, 24 Apr 2018 21:06:37 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 24, 2018 at 05:47:58PM +, Schmauss, Erik wrote: > > > > > > > > > > -Original Message- > > > >

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-25 Thread Igor Mammedov
On Tue, 24 Apr 2018 21:06:37 +0300 "Michael S. Tsirkin" wrote: > On Tue, Apr 24, 2018 at 05:47:58PM +, Schmauss, Erik wrote: > > > > > > > -Original Message- > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > Sent: Tuesday, April 24, 2018 10:43 AM > >

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2018 at 05:47:58PM +, Schmauss, Erik wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Tuesday, April 24, 2018 10:43 AM > > To: Igor Mammedov > > Cc: Schmauss, Erik ;

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-24 Thread Schmauss, Erik
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, April 24, 2018 10:43 AM > To: Igor Mammedov > Cc: Schmauss, Erik ; qemu-devel@nongnu.org; Xiao > Guangrong ; Williams,

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-24 Thread Michael S. Tsirkin
On Tue, Apr 24, 2018 at 09:57:22AM +0200, Igor Mammedov wrote: > On Tue, 24 Apr 2018 04:02:40 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 24, 2018 at 12:41:29AM +, Schmauss, Erik wrote: > > > > > > > > > > -Original Message- > > > > From: Michael S.

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-24 Thread Igor Mammedov
On Tue, 24 Apr 2018 04:02:40 +0300 "Michael S. Tsirkin" wrote: > On Tue, Apr 24, 2018 at 12:41:29AM +, Schmauss, Erik wrote: > > > > > > > -Original Message- > > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > > Sent: Monday, April 23, 2018 4:03 PM > > >

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-23 Thread Michael S. Tsirkin
On Tue, Apr 24, 2018 at 12:41:29AM +, Schmauss, Erik wrote: > > > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Monday, April 23, 2018 4:03 PM > > To: qemu-devel@nongnu.org > > Cc: Schmauss, Erik ; Igor Mammedov > >

Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-23 Thread Schmauss, Erik
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, April 23, 2018 4:03 PM > To: qemu-devel@nongnu.org > Cc: Schmauss, Erik ; Igor Mammedov > ; Xiao Guangrong > Subject:

[Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references

2018-04-23 Thread Michael S. Tsirkin
NVDIMM SSDT table references a name ("MEMA") before it is defined. This is reported to no longer be supported since Linux 4.17-rc1. While arguably Linux needs to keep working on old hypervisors, and other OSes seem fine with our behaviour, it seems cleaner to have the definition appear in the