Re: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-10 Thread Igor Mammedov
On Tue, 10 Jul 2018 02:26:35 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jul 09, 2018 at 08:19:17PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jul 09, 2018 at 05:52:32PM +0200, Igor Mammedov wrote: > > > On Fri, 6 Jul 2018 02:53:09 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > Var

Re: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 08:19:17PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 09, 2018 at 05:52:32PM +0200, Igor Mammedov wrote: > > On Fri, 6 Jul 2018 02:53:09 +0300 > > "Michael S. Tsirkin" wrote: > > > > > VarPackage can accept an expression evaluating to int, not just an int. > > > Change

Re: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 05:52:32PM +0200, Igor Mammedov wrote: > On Fri, 6 Jul 2018 02:53:09 +0300 > "Michael S. Tsirkin" wrote: > > > VarPackage can accept an expression evaluating to int, not just an int. > > Change the API to make it more generic. > > Further, rather than have users call the c

Re: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-09 Thread Igor Mammedov
On Fri, 6 Jul 2018 02:53:09 +0300 "Michael S. Tsirkin" wrote: > VarPackage can accept an expression evaluating to int, not just an int. > Change the API to make it more generic. > Further, rather than have users call the correct API depending on > value passed, use either PackageOp or VarPackageO

Re: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-05 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180705235305.124423-1-...@redhat.com Subject: [Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

[Qemu-devel] [PATCH] acpi: generalize aml_package / aml_varpackage

2018-07-05 Thread Michael S. Tsirkin
VarPackage can accept an expression evaluating to int, not just an int. Change the API to make it more generic. Further, rather than have users call the correct API depending on value passed, use either PackageOp or VarPackageOp automatically. Signed-off-by: Michael S. Tsirkin --- include/hw/acp