Nathan Froyd wrote:
On Thu, May 13, 2010 at 07:19:30PM +0200, Sebastian Herbszt wrote:
Convert enum to #define.
This doesn't buy you anything except code churn. It actually makes
things worse at usual debug levels, too, because the debugger
understands enums, but not #define.
-Nathan
Alex
Convert enum to #define.
Signed-off-by: Sebastian Herbszt herb...@gmx.de
diff --git a/hw/ahci.c b/hw/ahci.c
index 6f7b807..8d8605c 100644
--- a/hw/ahci.c
+++ b/hw/ahci.c
@@ -40,138 +40,124 @@ do { fprintf(stderr,ahci: fmt , ## __VA_ARGS__); }
while (0)
#define DPRINTF(fmt, ...) do {} while(0)
On Thu, May 13, 2010 at 07:19:30PM +0200, Sebastian Herbszt wrote:
Convert enum to #define.
This doesn't buy you anything except code churn. It actually makes
things worse at usual debug levels, too, because the debugger
understands enums, but not #define.
-Nathan
