Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-25 Thread Don Slutz
On 06/14/13 02:41, Evgeny Budilovsky wrote: On Fri, Jun 14, 2013 at 12:15 AM, Don Slutz > wrote: On 06/12/13 03:08, Evgeny Budilovsky wrote: The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be gen

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-13 Thread Evgeny Budilovsky
On Fri, Jun 14, 2013 at 12:15 AM, Don Slutz wrote: > On 06/12/13 03:08, Evgeny Budilovsky wrote: > >> The hard-coded 2k buffer on the stack won't allow reading big descriptor >> files which can be generated when storing big images (For example 500G >> vmdk splitted to 2G chunks). >> >> Signed-off

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-13 Thread Don Slutz
On 06/12/13 03:08, Evgeny Budilovsky wrote: The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G chunks). Signed-off-by: Evgeny Budilovsky --- block/vmdk.c | 28 +++

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
On Wed, Jun 12, 2013 at 1:30 PM, Kevin Wolf wrote: > Am 12.06.2013 um 10:04 hat Evgeny Budilovsky geschrieben: > > The hard-coded 2k buffer on the stack won't allow reading big descriptor > > files which can be generated when storing big images (For example 500G > > vmdk splitted to 2G chunks). >

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
On Wed, Jun 12, 2013 at 1:17 PM, Stefan Hajnoczi wrote: > On Wed, Jun 12, 2013 at 11:04:44AM +0300, Evgeny Budilovsky wrote: > > diff --git a/block/vmdk.c b/block/vmdk.c > > index 608daaf..1bc944b 100644 > > --- a/block/vmdk.c > > +++ b/block/vmdk.c > > @@ -719,27 +719,41 @@ static int vmdk_open_d

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Kevin Wolf
Am 12.06.2013 um 10:04 hat Evgeny Budilovsky geschrieben: > The hard-coded 2k buffer on the stack won't allow reading big descriptor > files which can be generated when storing big images (For example 500G > vmdk splitted to 2G chunks). > > Signed-off-by: Evgeny Budilovsky > --- > block/vmdk.c |

Re: [Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Stefan Hajnoczi
On Wed, Jun 12, 2013 at 11:04:44AM +0300, Evgeny Budilovsky wrote: > diff --git a/block/vmdk.c b/block/vmdk.c > index 608daaf..1bc944b 100644 > --- a/block/vmdk.c > +++ b/block/vmdk.c > @@ -719,27 +719,41 @@ static int vmdk_open_desc_file(BlockDriverState *bs, > int flags, >

[Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G chunks). Signed-off-by: Evgeny Budilovsky --- block/vmdk.c | 28 +--- 1 file changed, 21 insertions(+), 7

[Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G chunks). Signed-off-by: Evgeny Budilovsky --- block/vmdk.c | 28 +--- 1 file changed, 21 insertions(+), 7

[Qemu-devel] [PATCH] allow reading variable size vmdk descriptor files

2013-06-12 Thread Evgeny Budilovsky
The hard-coded 2k buffer on the stack won't allow reading big descriptor files which can be generated when storing big images (For example 500G vmdk splitted to 2G chunks). Signed-off-by: Evgeny Budilovsky --- block/vmdk.c | 28 +--- 1 file changed, 21 insertions(+), 7