Re: [Qemu-devel] [PATCH] allow to build with older sed

2018-01-19 Thread Eric Blake
On 01/19/2018 01:52 AM, Jan Beulich wrote: > sed's -E option may not be supported by older distros. As there's no > point using sed here at all, use just shell mechanisms to establish the > variable values, starting from the stem instead of the full target. Grammar in the subject ("allow to ${verb

Re: [Qemu-devel] [PATCH] allow to build with older sed

2018-01-19 Thread Philippe Mathieu-Daudé
On 01/19/2018 06:28 AM, Daniel P. Berrange wrote: > On Fri, Jan 19, 2018 at 12:52:27AM -0700, Jan Beulich wrote: >> sed's -E option may not be supported by older distros. As there's no >> point using sed here at all, use just shell mechanisms to establish the >> variable values, starting from the s

Re: [Qemu-devel] [PATCH] allow to build with older sed

2018-01-19 Thread Daniel P. Berrange
On Fri, Jan 19, 2018 at 12:52:27AM -0700, Jan Beulich wrote: > sed's -E option may not be supported by older distros. As there's no > point using sed here at all, use just shell mechanisms to establish the > variable values, starting from the stem instead of the full target. > > Signed-off-by: Jan

[Qemu-devel] [PATCH] allow to build with older sed

2018-01-18 Thread Jan Beulich
sed's -E option may not be supported by older distros. As there's no point using sed here at all, use just shell mechanisms to establish the variable values, starting from the stem instead of the full target. Signed-off-by: Jan Beulich --- a/Makefile +++ b/Makefile @@ -242,8 +242,7 @@ GENERATED_