Re: [Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-15 Thread Mohammed Gamal
On Fri, 2017-09-15 at 10:07 +0800, Peter Xu wrote: > On Thu, Sep 14, 2017 at 05:31:38PM -0300, Eduardo Habkost wrote: > > On Thu, Sep 14, 2017 at 10:24:23PM +0200, Thomas Huth wrote: > > > On 14.09.2017 22:18, Mohammed Gamal wrote: > > > > Starting the following command line causes a segfault > >

Re: [Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Peter Xu
On Thu, Sep 14, 2017 at 05:31:38PM -0300, Eduardo Habkost wrote: > On Thu, Sep 14, 2017 at 10:24:23PM +0200, Thomas Huth wrote: > > On 14.09.2017 22:18, Mohammed Gamal wrote: > > > Starting the following command line causes a segfault > > > qemu-system-x86_64 -S -machine isapc,accel=kvm -device

Re: [Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Eduardo Habkost
On Thu, Sep 14, 2017 at 10:24:23PM +0200, Thomas Huth wrote: > On 14.09.2017 22:18, Mohammed Gamal wrote: > > Starting the following command line causes a segfault > > qemu-system-x86_64 -S -machine isapc,accel=kvm -device amd-iommu > > > > This is due to the fact that the machine type 'isapc'

Re: [Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Thomas Huth
On 14.09.2017 22:18, Mohammed Gamal wrote: > Starting the following command line causes a segfault > qemu-system-x86_64 -S -machine isapc,accel=kvm -device amd-iommu > > This is due to the fact that the machine type 'isapc' doesn't have > a PCI bus, while amd_iommu doesn't check if the machine

[Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Mohammed Gamal
Starting the following command line causes a segfault qemu-system-x86_64 -S -machine isapc,accel=kvm -device amd-iommu This is due to the fact that the machine type 'isapc' doesn't have a PCI bus, while amd_iommu doesn't check if the machine has PCI support and subsequently does a null-pointer

[Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Mohammed Gamal
Starting the following command line causes a segfault qemu-system-x86_64 -S -machine isapc,accel=kvm -device amd-iommu This is due to the fact that the machine type 'isapc' doesn't have a PCI bus, while amd_iommu doesn't check if the machine has PCI support and subsequently does a null-pointer