Re: [Qemu-devel] [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-10-27 Thread Eduardo Habkost
On Tue, Oct 27, 2015 at 03:51:31PM +0300, Pavel Fedin wrote: > Currently hostmem backend fails if CONFIG_NUMA is enabled for the qemu > (default), but NUMA is not supported by the kernel. This makes it > impossible to use ivshmem in such configurations. > > This patch fixes the problem by ignoring

[Qemu-devel] [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-10-27 Thread Pavel Fedin
Currently hostmem backend fails if CONFIG_NUMA is enabled for the qemu (default), but NUMA is not supported by the kernel. This makes it impossible to use ivshmem in such configurations. This patch fixes the problem by ignoring ENOSYS error if policy is set to MPOL_DEFAULT. This way the code behav

Re: [Qemu-devel] [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-10-27 Thread Pavel Fedin
sung@nongnu.org [mailto:qemu-devel- > bounces+p.fedin=samsung@nongnu.org] On Behalf Of Pavel Fedin > Sent: Tuesday, October 27, 2015 3:52 PM > To: qemu-devel@nongnu.org > Cc: 'Paolo Bonzini'; 'Eduardo Habkost' > Subject: [Qemu-devel] [PATCH] backends/hostmem: Igno

[Qemu-devel] [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-10-27 Thread Pavel Fedin
Currently hostmem backend fails if CONFIG_NUMA is enabled for the qemu (default), but NUMA is not supported by the kernel. This makes it impossible to use ivshmem in such configurations. This patch fixes the problem by ignoring ENOSYS error if policy is set to MPOL_DEFAULT. This way the code behav

Re: [Qemu-devel] [PATCH] backends/hostmem: Ignore ENOSYS while setting MPOL_DEFAULT

2015-10-27 Thread Paolo Bonzini
On 27/10/2015 13:11, Pavel Fedin wrote: > +if ((backend->policy != MPOL_DEFAULT) || (errno != ENOSYS)) { Can you remove parentheses around conditions? Paolo > +error_setg_errno(errp, errno, > "cannot bind memory to host NUMA nodes"); >