Re: [Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1

2017-12-12 Thread Paolo Bonzini
On 11/12/2017 15:51, Samuel Thibault wrote: >> Is magic clamping desirable, or is it better to make it a hard error if >> the user configured a size that is not possible? > The thing is: the user didn't configure something, she just happened to > use a braille device bigger than 84 to display qemu'

Re: [Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1

2017-12-11 Thread Samuel Thibault
Eric Blake, on lun. 11 déc. 2017 08:30:39 -0600, wrote: > On 12/10/2017 06:19 PM, Samuel Thibault wrote: > > Baum device bigger than 84 do not actually exist, some guest drivers > > would be upset by such sizes. > > > > Signed-off-by: Samuel Thibault > > --- > > chardev/baum.c | 8 +++- > >

Re: [Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1

2017-12-11 Thread Eric Blake
On 12/10/2017 06:19 PM, Samuel Thibault wrote: > Baum device bigger than 84 do not actually exist, some guest drivers > would be upset by such sizes. > > Signed-off-by: Samuel Thibault > --- > chardev/baum.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > @@ -239,6 +239,12 @

[Qemu-devel] [PATCH] baum: Truncate braille device size to 84x1

2017-12-10 Thread Samuel Thibault
Baum device bigger than 84 do not actually exist, some guest drivers would be upset by such sizes. Signed-off-by: Samuel Thibault --- chardev/baum.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/chardev/baum.c b/chardev/baum.c index 67fd783a59..78b0c87625 100644 ---