Re: [Qemu-devel] [PATCH] block/iscsi: statically link qemu_iscsi_opts

2017-01-24 Thread Paolo Bonzini
On 24/01/2017 13:49, Peter Lieven wrote: > +#ifdef CONFIG_LIBISCSI The #ifdef is not needed here. Paolo > +static QemuOptsList qemu_iscsi_opts = { > +.name = "iscsi", > +.head = QTAILQ_HEAD_INITIALIZER(qemu_iscsi_opts.head), > +.desc = { > +{ > +.name = "user",

[Qemu-devel] [PATCH] block/iscsi: statically link qemu_iscsi_opts

2017-01-24 Thread Peter Lieven
commit f57b4b5f moved qemu_iscsi_opts into vl.c. This made them invisible for qemu-img, qemu-nbd etc. Fixes: f57b4b5fb127b60e1aade2684a8b16bc4f630b29 Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- MAINTAINERS | 1 + block/Makefile.objs | 1 + block/iscsi-opts.c | 71 ++

Re: [Qemu-devel] [PATCH] block/iscsi: statically link qemu_iscsi_opts

2017-01-24 Thread Paolo Bonzini
On 24/01/2017 13:53, Peter Lieven wrote: > Am 24.01.2017 um 13:52 schrieb Paolo Bonzini: >> >> On 24/01/2017 13:49, Peter Lieven wrote: >>> +#ifdef CONFIG_LIBISCSI >> The #ifdef is not needed here. > > Right, can you drop it or shall I send a V2? Can do. Paolo > Peter > >> >> Paolo >> >>> +s

Re: [Qemu-devel] [PATCH] block/iscsi: statically link qemu_iscsi_opts

2017-01-24 Thread Peter Lieven
Am 24.01.2017 um 13:52 schrieb Paolo Bonzini: On 24/01/2017 13:49, Peter Lieven wrote: +#ifdef CONFIG_LIBISCSI The #ifdef is not needed here. Right, can you drop it or shall I send a V2? Peter Paolo +static QemuOptsList qemu_iscsi_opts = { +.name = "iscsi", +.head = QTAILQ_HEAD