Re: [Qemu-devel] [PATCH] block/linux-aio: Drop unused BlockAIOCB submission method

2019-06-03 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190602201709.11901-1-jus...@mail.ru/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH] block/linux-aio: Drop unused BlockAIOCB submission method Type: series Message-id

Re: [Qemu-devel] [PATCH] block/linux-aio: Drop unused BlockAIOCB submission method

2019-06-03 Thread Kevin Wolf
Am 02.06.2019 um 22:17 hat Julia Suvorova geschrieben: > Callback-based laio_submit() and laio_cancel() were left after > rewriting Linux AIO backend to coroutines in hope that they would be > used in other code that could bypass coroutines. They can be safely > removed because they have not been

Re: [Qemu-devel] [PATCH] block/linux-aio: Drop unused BlockAIOCB submission method

2019-06-03 Thread Stefan Hajnoczi
On Sun, Jun 02, 2019 at 11:17:09PM +0300, Julia Suvorova via Qemu-devel wrote: > Callback-based laio_submit() and laio_cancel() were left after > rewriting Linux AIO backend to coroutines in hope that they would be > used in other code that could bypass coroutines. They can be safely > removed

[Qemu-devel] [PATCH] block/linux-aio: Drop unused BlockAIOCB submission method

2019-06-02 Thread Julia Suvorova via Qemu-devel
Callback-based laio_submit() and laio_cancel() were left after rewriting Linux AIO backend to coroutines in hope that they would be used in other code that could bypass coroutines. They can be safely removed because they have not been used since that time. Signed-off-by: Julia Suvorova ---