Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-06-29 Thread Alexandre DERUMIER
qemu-bl...@nongnu.org Envoyé: Mardi 16 Juin 2015 06:06:25 Objet: Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning On Wed, May 13, 2015 at 11:11:13AM +0800, Fam Zheng wrote: > Before, we only yield after initializing dirty bitmap, where the QMP > command w

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-06-15 Thread Jeff Cody
On Wed, May 13, 2015 at 11:11:13AM +0800, Fam Zheng wrote: > Before, we only yield after initializing dirty bitmap, where the QMP > command would return. That may take very long, and guest IO will be > blocked. > > Add sleep points like the later mirror iterations. > > Signed-off-by: Fam Zheng >

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-06-04 Thread Wen Congyang
On 05/13/2015 02:40 PM, Fam Zheng wrote: > On Wed, 05/13 13:17, Wen Congyang wrote: >> On 05/13/2015 11:11 AM, Fam Zheng wrote: >>> Before, we only yield after initializing dirty bitmap, where the QMP >>> command would return. That may take very long, and guest IO will be >>> blocked. >> >> Do you

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-13 Thread Paolo Bonzini
On 13/05/2015 05:11, Fam Zheng wrote: > Before, we only yield after initializing dirty bitmap, where the QMP > command would return. That may take very long, and guest IO will be > blocked. > > Add sleep points like the later mirror iterations. You were also planning to let bdrv_co_is_allocated

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-13 Thread Wen Congyang
On 05/13/2015 11:11 AM, Fam Zheng wrote: > Before, we only yield after initializing dirty bitmap, where the QMP > command would return. That may take very long, and guest IO will be > blocked. > > Add sleep points like the later mirror iterations. > > Signed-off-by: Fam Zheng Reviewed-by: Wen C

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-12 Thread Fam Zheng
On Wed, 05/13 13:17, Wen Congyang wrote: > On 05/13/2015 11:11 AM, Fam Zheng wrote: > > Before, we only yield after initializing dirty bitmap, where the QMP > > command would return. That may take very long, and guest IO will be > > blocked. > > Do you have such case to reproduce it? If the disk i

Re: [Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-12 Thread Wen Congyang
On 05/13/2015 11:11 AM, Fam Zheng wrote: > Before, we only yield after initializing dirty bitmap, where the QMP > command would return. That may take very long, and guest IO will be > blocked. Do you have such case to reproduce it? If the disk image is too larger, and I think qemu doesn't cache al

[Qemu-devel] [PATCH] block/mirror: Sleep periodically during bitmap scanning

2015-05-12 Thread Fam Zheng
Before, we only yield after initializing dirty bitmap, where the QMP command would return. That may take very long, and guest IO will be blocked. Add sleep points like the later mirror iterations. Signed-off-by: Fam Zheng --- block/mirror.c | 13 - 1 file changed, 12 insertions(+),