Re: [Qemu-devel] [PATCH] block/mirror: limit qiov to IOV_MAX elements

2015-08-06 Thread Jeff Cody
On Wed, Jul 01, 2015 at 03:45:50PM +0100, Stefan Hajnoczi wrote: > If mirror has more free buffers than IOV_MAX, preadv(2)/pwritev(2) > EINVAL failures may be encountered. > > It is possible to trigger this by setting granularity to a low value > like 8192. > > This patch stops appending chunks o

Re: [Qemu-devel] [PATCH] block/mirror: limit qiov to IOV_MAX elements

2015-07-01 Thread Paolo Bonzini
On 01/07/2015 16:45, Stefan Hajnoczi wrote: > If mirror has more free buffers than IOV_MAX, preadv(2)/pwritev(2) > EINVAL failures may be encountered. > > It is possible to trigger this by setting granularity to a low value > like 8192. > > This patch stops appending chunks once IOV_MAX is reac

[Qemu-devel] [PATCH] block/mirror: limit qiov to IOV_MAX elements

2015-07-01 Thread Stefan Hajnoczi
If mirror has more free buffers than IOV_MAX, preadv(2)/pwritev(2) EINVAL failures may be encountered. It is possible to trigger this by setting granularity to a low value like 8192. This patch stops appending chunks once IOV_MAX is reached. The spurious EINVAL failure can be reproduced with a q