Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Pádraig Brady
On 09/25/2014 10:00 AM, Tony Breeds wrote: > On Thu, Sep 25, 2014 at 09:30:30AM +0200, Kevin Wolf wrote: > >> Does this fix the problem or does it just make it less likely that it >> becomes apparent? > > Sorry for not making this clearer in my commit message. > > I haven't been able to reproduc

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Eric Blake
On 09/25/2014 01:30 AM, Kevin Wolf wrote: > Am 25.09.2014 um 08:21 hat Markus Armbruster geschrieben: >> Please copy Kevin & Stefan for block patches. Doing that for you. I >> also copy Max, who left his fingerprints on commit 4f11aa8. >> >> Tony Breeds writes: >> >>> The command >>> qemu-img

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Eric Blake
On 09/24/2014 11:23 PM, Tony Breeds wrote: > The command > qemu-img convert -O raw inputimage.qcow2 outputimage.raw > > intermittently creates corrupted output images, when the input image is not yet fully synchronized to disk. This patch preferese the use of seek_hole checks to determine if th

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 11:00 hat Tony Breeds geschrieben: > On Thu, Sep 25, 2014 at 09:30:30AM +0200, Kevin Wolf wrote: > > > Does this fix the problem or does it just make it less likely that it > > becomes apparent? > > Sorry for not making this clearer in my commit message. > > I haven't been able

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Tony Breeds
On Thu, Sep 25, 2014 at 09:30:30AM +0200, Kevin Wolf wrote: > Does this fix the problem or does it just make it less likely that it > becomes apparent? Sorry for not making this clearer in my commit message. I haven't been able to reproduce the corruption with the fiemap flag change. > If ther

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 08:21 hat Markus Armbruster geschrieben: > Please copy Kevin & Stefan for block patches. Doing that for you. I > also copy Max, who left his fingerprints on commit 4f11aa8. > > Tony Breeds writes: > > > The command > > qemu-img convert -O raw inputimage.qcow2 outputimage.raw

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-24 Thread Tony Breeds
On Thu, Sep 25, 2014 at 08:42:25AM +0200, Greg Kurz wrote: > Same path : ./scripts/get_maintainer.pl Thanks Greg. Now I know :) Tony. pgp2j8su8SSSV.pgp Description: PGP signature

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-24 Thread Markus Armbruster
Tony Breeds writes: > On Thu, Sep 25, 2014 at 08:21:27AM +0200, Markus Armbruster wrote: >> Please copy Kevin & Stefan for block patches. Doing that for you. I >> also copy Max, who left his fingerprints on commit 4f11aa8. > > Sorry. > > Is there a qemu version of get_maintainers.pl? Yes :) $

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-24 Thread Greg Kurz
On Thu, 25 Sep 2014 16:29:31 +1000 Tony Breeds wrote: > On Thu, Sep 25, 2014 at 08:21:27AM +0200, Markus Armbruster wrote: > > Please copy Kevin & Stefan for block patches. Doing that for you. I > > also copy Max, who left his fingerprints on commit 4f11aa8. > > Sorry. > > Is there a qemu ver

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-24 Thread Tony Breeds
On Thu, Sep 25, 2014 at 08:21:27AM +0200, Markus Armbruster wrote: > Please copy Kevin & Stefan for block patches. Doing that for you. I > also copy Max, who left his fingerprints on commit 4f11aa8. Sorry. Is there a qemu version of get_maintainers.pl? Tony. pgpYwsSX2dsBU.pgp Description: PG

Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-24 Thread Markus Armbruster
Please copy Kevin & Stefan for block patches. Doing that for you. I also copy Max, who left his fingerprints on commit 4f11aa8. Tony Breeds writes: > The command > qemu-img convert -O raw inputimage.qcow2 outputimage.raw > > intermittently creates corrupted output images, when the input imag

[Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of fiemap

2014-09-24 Thread Tony Breeds
The command qemu-img convert -O raw inputimage.qcow2 outputimage.raw intermittently creates corrupted output images, when the input image is not yet fully synchronized to disk. This patch preferese the use of seek_hole checks to determine if the sector is present in the disk image. While we'