Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Kevin Wolf
Am 03.02.2012 01:16, schrieb Charles Arnold: Next version of the patch with fixes, cleanups, and suggestions. - Charles The Virtual Hard Disk Image Format Specification allows for three types of hard disk formats, Fixed, Dynamic, and Differencing. Qemu currently only supports Dynamic

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Charles Arnold
On 2/6/2012 at 08:46 AM, in message 4f2ff5b9.9090...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Somehow you lost the ret = -EFBIG here. Otherwise the patch looks good enough for me. Kevin Thanks Kevin. Here is the revised patch with just this fix. - Charles The Virtual Hard

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Kevin Wolf
Am 06.02.2012 17:22, schrieb Charles Arnold: On 2/6/2012 at 08:46 AM, in message 4f2ff5b9.9090...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Somehow you lost the ret = -EFBIG here. Otherwise the patch looks good enough for me. Kevin Thanks Kevin. Here is the revised patch with

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-06 Thread Charles Arnold
On 2/6/2012 at 09:51 AM, in message 4f3004fc.7070...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Am 06.02.2012 17:22, schrieb Charles Arnold: On 2/6/2012 at 08:46 AM, in message 4f2ff5b9.9090...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Somehow you lost the ret = -EFBIG here.

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-02 Thread Kevin Wolf
Am 01.02.2012 17:51, schrieb Charles Arnold: On 2/1/2012 at 05:15 AM, in message 4f292cd0.20...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Am 01.02.2012 00:04, schrieb Charles Arnold: Thanks Andreas, The 'TODO uuid is missing' comment in the patch is from the original sources (as well

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-02 Thread Charles Arnold
Next version of the patch with fixes, cleanups, and suggestions. - Charles The Virtual Hard Disk Image Format Specification allows for three types of hard disk formats, Fixed, Dynamic, and Differencing. Qemu currently only supports Dynamic disks. This patch adds support for the Fixed Disk

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-01 Thread Kevin Wolf
Am 01.02.2012 00:04, schrieb Charles Arnold: Thanks Andreas, The 'TODO uuid is missing' comment in the patch is from the original sources (as well as many '//' comments). The vhd footer and header data structures contain a field for a UUID but no code was ever developed to generate one.

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-01 Thread Charles Arnold
On 2/1/2012 at 05:15 AM, in message 4f292cd0.20...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Am 01.02.2012 00:04, schrieb Charles Arnold: Thanks Andreas, The 'TODO uuid is missing' comment in the patch is from the original sources (as well as many '//' comments). The vhd footer

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-02-01 Thread Stefan Weil
Am 01.02.2012 17:51, schrieb Charles Arnold: On 2/1/2012 at 05:15 AM, in message4f292cd0.20...@redhat.com, Kevin Wolf kw...@redhat.com wrote: Am 01.02.2012 00:04, schrieb Charles Arnold: Thanks Andreas, The 'TODO uuid is missing' comment in the patch is from the original

[Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-01-31 Thread Charles Arnold
The Virtual Hard Disk Image Format Specification allows for three types of hard disk formats, Fixed, Dynamic, and Differencing. Qemu currently only supports Dynamic disks. This patch adds support for the Fixed Disk format. Usage: Example 1: qemu-img create -f vpc -o type=fixed filename

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-01-31 Thread Andreas Färber
Hello Charles, Am 31.01.2012 20:03, schrieb Charles Arnold: The Virtual Hard Disk Image Format Specification allows for three types of hard disk formats, Fixed, Dynamic, and Differencing. Qemu currently only supports Dynamic disks. This patch adds support for the Fixed Disk format.

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-01-31 Thread Charles Arnold
Thanks Andreas, The 'TODO uuid is missing' comment in the patch is from the original sources (as well as many '//' comments). The vhd footer and header data structures contain a field for a UUID but no code was ever developed to generate one. The revised patch is below after running

Re: [Qemu-devel] [PATCH] block: Add support for vpc Fixed Disk type

2012-01-31 Thread Andreas Färber
Am 01.02.2012 00:04, schrieb Charles Arnold: The Virtual Hard Disk Image Format Specification allows for three types of hard disk formats, Fixed, Dynamic, and Differencing. Qemu currently only supports Dynamic disks. This patch adds support for the Fixed Disk format. Usage: Example