Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Eric Blake
On 11/08/2017 04:04 AM, Kevin Wolf wrote: > > Well, they don't only need an explicitly set option, but the important > point is that they don't work with the default value. But I can add > something to this effect. > >>> +++ b/block/vvfat.c >>> @@ -1259,7 +1259,11 @@ static int vvfat_open(BlockD

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 12:51:27PM +0100, Kevin Wolf wrote: > Am 08.11.2017 um 11:49 hat Daniel P. Berrange geschrieben: > > On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: > > > On 07/11/2017 18:39, Daniel P. Berrange wrote: > > > > On Tue, Nov 07, 2017 at 06:26:38PM +0100, Kevin Wo

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Kevin Wolf
Am 08.11.2017 um 13:00 hat Paolo Bonzini geschrieben: > On 08/11/2017 12:51, Kevin Wolf wrote: > > Am 08.11.2017 um 11:49 hat Daniel P. Berrange geschrieben: > >> On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: > >>> I am not sure this counts as deprecation, but it should go in the >

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Paolo Bonzini
On 08/11/2017 12:51, Kevin Wolf wrote: > Am 08.11.2017 um 11:49 hat Daniel P. Berrange geschrieben: >> On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: >>> I am not sure this counts as deprecation, but it should go in the >>> release notes as "future incompatible changes", and that se

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Kevin Wolf
Am 08.11.2017 um 11:49 hat Daniel P. Berrange geschrieben: > On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: > > On 07/11/2017 18:39, Daniel P. Berrange wrote: > > > On Tue, Nov 07, 2017 at 06:26:38PM +0100, Kevin Wolf wrote: > > >> bdrv_set_read_only() is used by some block drivers

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: > On 07/11/2017 18:39, Daniel P. Berrange wrote: > > On Tue, Nov 07, 2017 at 06:26:38PM +0100, Kevin Wolf wrote: > >> bdrv_set_read_only() is used by some block drivers to override the > >> read-only option given by the user. This is no

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Paolo Bonzini
On 07/11/2017 18:39, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 06:26:38PM +0100, Kevin Wolf wrote: >> bdrv_set_read_only() is used by some block drivers to override the >> read-only option given by the user. This is not how read-only images >> generally work in QEMU: Instead of second gue

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Kevin Wolf
Am 07.11.2017 um 21:29 hat Eric Blake geschrieben: > On 11/07/2017 11:26 AM, Kevin Wolf wrote: > > bdrv_set_read_only() is used by some block drivers to override the > > read-only option given by the user. This is not how read-only images > > generally work in QEMU: Instead of second guessing what

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-07 Thread Eric Blake
On 11/07/2017 11:26 AM, Kevin Wolf wrote: > bdrv_set_read_only() is used by some block drivers to override the > read-only option given by the user. This is not how read-only images > generally work in QEMU: Instead of second guessing what the user really > meant (which currently includes making an

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-07 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 06:26:38PM +0100, Kevin Wolf wrote: > bdrv_set_read_only() is used by some block drivers to override the > read-only option given by the user. This is not how read-only images > generally work in QEMU: Instead of second guessing what the user really > meant (which currently

[Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-07 Thread Kevin Wolf
bdrv_set_read_only() is used by some block drivers to override the read-only option given by the user. This is not how read-only images generally work in QEMU: Instead of second guessing what the user really meant (which currently includes making an image read-only even if the user didn't only use