Re: [Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Jeff Cody
On Fri, Jan 24, 2014 at 05:00:45PM +0100, Kevin Wolf wrote: > Am 24.01.2014 um 16:56 hat Jeff Cody geschrieben: > > On Fri, Jan 24, 2014 at 02:08:21PM +0100, Kevin Wolf wrote: > > > bdrv_commit() could return 0 or 1 on success, depending on whether or > > > now the last sector was allocated in the

Re: [Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Kevin Wolf
Am 24.01.2014 um 16:56 hat Jeff Cody geschrieben: > On Fri, Jan 24, 2014 at 02:08:21PM +0100, Kevin Wolf wrote: > > bdrv_commit() could return 0 or 1 on success, depending on whether or > > now the last sector was allocated in the overlay and whether the overlay > > format had a .bdrv_make_empty ca

Re: [Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Jeff Cody
On Fri, Jan 24, 2014 at 02:08:21PM +0100, Kevin Wolf wrote: > bdrv_commit() could return 0 or 1 on success, depending on whether or > now the last sector was allocated in the overlay and whether the overlay > format had a .bdrv_make_empty callback. > > Most callers ignored it, but qemu-img commit

Re: [Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Benoît Canet
Le Friday 24 Jan 2014 à 14:08:21 (+0100), Kevin Wolf a écrit : > bdrv_commit() could return 0 or 1 on success, depending on whether or > now the last sector was allocated in the overlay and whether the overlay > format had a .bdrv_make_empty callback. > > Most callers ignored it, but qemu-img comm

[Qemu-devel] [PATCH] block: Fix bdrv_commit return value

2014-01-24 Thread Kevin Wolf
bdrv_commit() could return 0 or 1 on success, depending on whether or now the last sector was allocated in the overlay and whether the overlay format had a .bdrv_make_empty callback. Most callers ignored it, but qemu-img commit would print an error message while the operation actually succeeded.

Re: [Qemu-devel] [PATCH] block: Fix bdrv_commit

2010-05-06 Thread Christoph Hellwig
On Thu, May 06, 2010 at 04:44:34PM +0200, Kevin Wolf wrote: > When reopening the image, don't guess the driver, but use the same driver as > was used before. This is important if the format=... option was used for that > image. > > Signed-off-by: Kevin Wolf Looks good, Reviewed-by: Christoph H

[Qemu-devel] [PATCH] block: Fix bdrv_commit

2010-05-06 Thread Kevin Wolf
When reopening the image, don't guess the driver, but use the same driver as was used before. This is important if the format=... option was used for that image. Signed-off-by: Kevin Wolf --- block.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/block.c b/block.c