Re: [Qemu-devel] [PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers

2018-04-25 Thread Kevin Wolf
Am 25.04.2018 um 10:06 hat Daniel P. Berrangé geschrieben: > On Tue, Apr 24, 2018 at 05:01:57PM -0500, Eric Blake wrote: > > We have too many driver callback interfaces; simplify the mess > > somewhat by merging the flags parameter of .bdrv_co_writev_flags() > > into .bdrv_co_writev_flags(). Note

Re: [Qemu-devel] [PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers

2018-04-25 Thread Daniel P . Berrangé
On Tue, Apr 24, 2018 at 05:01:57PM -0500, Eric Blake wrote: > We have too many driver callback interfaces; simplify the mess > somewhat by merging the flags parameter of .bdrv_co_writev_flags() > into .bdrv_co_writev_flags(). Note that as long as a driver doesn't Typo - this should be just

[Qemu-devel] [PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers

2018-04-24 Thread Eric Blake
We have too many driver callback interfaces; simplify the mess somewhat by merging the flags parameter of .bdrv_co_writev_flags() into .bdrv_co_writev_flags(). Note that as long as a driver doesn't set .supported_write_flags, the flags argument will be 0 and behavior is identical. Also note that