[Qemu-devel] [PATCH] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-03 Thread Benoît Canet
This patch keep the recursive way of doing things but simplify it by giving two responsabilities to all block filters implementors. They will need to do two things: -Set the is_filter field of their block driver to true. -Implement the bdrv_recurse_is_first_non_filter method of their block

Re: [Qemu-devel] [PATCH] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-03 Thread Paolo Bonzini
Il 03/03/2014 19:11, Benoît Canet ha scritto: diff --git a/block/blkverify.c b/block/blkverify.c index b98b08b..e1c3117 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -288,6 +288,20 @@ static BlockDriverAIOCB *blkverify_aio_flush(BlockDriverState *bs, return

Re: [Qemu-devel] [PATCH] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-03 Thread Benoît Canet
The Monday 03 Mar 2014 à 19:35:13 (+0100), Paolo Bonzini wrote : Il 03/03/2014 19:11, Benoît Canet ha scritto: diff --git a/block/blkverify.c b/block/blkverify.c index b98b08b..e1c3117 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -288,6 +288,20 @@ static BlockDriverAIOCB

Re: [Qemu-devel] [PATCH] block: Rewrite the snapshot authorization mechanism for block filters.

2014-03-03 Thread Paolo Bonzini
Il 03/03/2014 20:13, Benoît Canet ha scritto: Hmm I did not even though it was a bug, I merely rewrote the code to adapt to the new way of doing. Should I mention the bugfix and repost ? Up to Kevin. Paolo