Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 12:26:41PM -0700, Eric Blake wrote: > On 11/05/2013 12:03 PM, Max Reitz wrote: > > error_setg_errno() may overwrite errno; therefore, its value should be > > read before calling that function and not afterwards. > > > > Signed-off-by: Max Reitz > > --- > > block.c | 2 +-

Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-06 Thread Stefan Hajnoczi
On Tue, Nov 05, 2013 at 08:03:33PM +0100, Max Reitz wrote: > error_setg_errno() may overwrite errno; therefore, its value should be > read before calling that function and not afterwards. > > Signed-off-by: Max Reitz > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks

Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-05 Thread Benoît Canet
Le Tuesday 05 Nov 2013 à 20:03:33 (+0100), Max Reitz a écrit : > error_setg_errno() may overwrite errno; therefore, its value should be > read before calling that function and not afterwards. > > Signed-off-by: Max Reitz > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-05 Thread Eric Blake
On 11/05/2013 12:03 PM, Max Reitz wrote: > error_setg_errno() may overwrite errno; therefore, its value should be > read before calling that function and not afterwards. > > Signed-off-by: Max Reitz > --- > block.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Eric Blake

[Qemu-devel] [PATCH] block: Save errno before error_setg_errno

2013-11-05 Thread Max Reitz
error_setg_errno() may overwrite errno; therefore, its value should be read before calling that function and not afterwards. Signed-off-by: Max Reitz --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 58efb5b..0e96a22 100644 --- a/block.c +++