Re: [Qemu-devel] [PATCH] block: drop bs_snapshots global variable

2013-03-15 Thread Wenchao Xia
This fix my problem in moving code to block/snapshot.c. Reviewed-by: Wenchao Xia xiaw...@linux.vnet.ibm.com -- Best Regards Wenchao Xia

[Qemu-devel] [PATCH] block: drop bs_snapshots global variable

2013-03-14 Thread Stefan Hajnoczi
The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept but was moved into block.c:bdrv_snapshots() when it became clear that hotplug could result in a dangling pointer. While auditing the block layer's global state I

Re: [Qemu-devel] [PATCH] block: drop bs_snapshots global variable

2013-03-14 Thread Eric Blake
On 03/14/2013 10:04 AM, Stefan Hajnoczi wrote: The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept but was moved into block.c:bdrv_snapshots() when it became clear that hotplug could result in a dangling