Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-10 Thread Kevin Wolf
Am 10.01.2014 um 20:03 hat Peter Feiner geschrieben: > On Fri, Jan 10, 2014 at 1:26 PM, Kevin Wolf wrote: > > Am 10.01.2014 um 19:05 hat Max Reitz geschrieben: > >> On 10.01.2014 18:55, Kevin Wolf wrote: > >> >Ok, if you're happy with it, I'll apply it. Can I put your Reviewed-by > >> >there? > >>

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-10 Thread Peter Feiner
On Fri, Jan 10, 2014 at 1:26 PM, Kevin Wolf wrote: > Am 10.01.2014 um 19:05 hat Max Reitz geschrieben: >> On 10.01.2014 18:55, Kevin Wolf wrote: >> >Ok, if you're happy with it, I'll apply it. Can I put your Reviewed-by >> >there? >> >> Yes, feel free to. > > Thanks, applied to the block branch. >

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-10 Thread Kevin Wolf
Am 10.01.2014 um 19:38 hat Max Reitz geschrieben: > On 10.01.2014 19:26, Kevin Wolf wrote: > >Am 10.01.2014 um 19:05 hat Max Reitz geschrieben: > >>On 10.01.2014 18:55, Kevin Wolf wrote: > >>>Ok, if you're happy with it, I'll apply it. Can I put your Reviewed-by > >>>there? > >>Yes, feel free to. >

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-10 Thread Kevin Wolf
Am 10.01.2014 um 19:05 hat Max Reitz geschrieben: > On 10.01.2014 18:55, Kevin Wolf wrote: > >Ok, if you're happy with it, I'll apply it. Can I put your Reviewed-by > >there? > > Yes, feel free to. Thanks, applied to the block branch. Peter, no need for a second version of the patch then. :-) >

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-10 Thread Max Reitz
On 10.01.2014 19:26, Kevin Wolf wrote: Am 10.01.2014 um 19:05 hat Max Reitz geschrieben: On 10.01.2014 18:55, Kevin Wolf wrote: Ok, if you're happy with it, I'll apply it. Can I put your Reviewed-by there? Yes, feel free to. Thanks, applied to the block branch. Peter, no need for a second ve

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-10 Thread Max Reitz
On 10.01.2014 18:55, Kevin Wolf wrote: Am 10.01.2014 um 18:27 hat Max Reitz geschrieben: On 09.01.2014 11:59, Kevin Wolf wrote: [ CCing Max, who was recently active in this area, for another opinion ] Am 08.01.2014 um 20:43 hat Peter Feiner geschrieben: When a backing file is opened such that

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-10 Thread Kevin Wolf
Am 10.01.2014 um 18:27 hat Max Reitz geschrieben: > On 09.01.2014 11:59, Kevin Wolf wrote: > >[ CCing Max, who was recently active in this area, for another opinion ] > > > >Am 08.01.2014 um 20:43 hat Peter Feiner geschrieben: > >>When a backing file is opened such that (1) a protocol is directly >

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-10 Thread Max Reitz
On 09.01.2014 11:59, Kevin Wolf wrote: [ CCing Max, who was recently active in this area, for another opinion ] Am 08.01.2014 um 20:43 hat Peter Feiner geschrieben: When a backing file is opened such that (1) a protocol is directly used as the block driver and (2) the block driver has bdrv_file

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-09 Thread Peter Feiner
On Thu, Jan 9, 2014 at 5:59 AM, Kevin Wolf wrote: > I think if there is no bs->backing_hd->file, we should get the filename > from bs->backing_hd->filename instead of leaving it empty. > > In fact, can we always do that or does bs->backing_hd normally lack the > filename? If so, perhaps that is wh

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-09 Thread Kevin Wolf
[ CCing Max, who was recently active in this area, for another opinion ] Am 08.01.2014 um 20:43 hat Peter Feiner geschrieben: > When a backing file is opened such that (1) a protocol is directly > used as the block driver and (2) the block driver has bdrv_file_open, > bdrv_open_backing_file segfau

Re: [Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-08 Thread Fam Zheng
Hi Peter, Thank your for catching this. On 2014年01月09日 03:43, Peter Feiner wrote: When a backing file is opened such that (1) a protocol is directly used as the block driver and (2) the block driver has bdrv_file_open, bdrv_open_backing_file segfaults. The problem arises because bdrv_open_comm

[Qemu-devel] [PATCH] block: fix backing file segfault

2014-01-08 Thread Peter Feiner
When a backing file is opened such that (1) a protocol is directly used as the block driver and (2) the block driver has bdrv_file_open, bdrv_open_backing_file segfaults. The problem arises because bdrv_open_common returns without setting bd->backing_hd->file. To effect (1), you seem to have to us