Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

2010-01-26 Thread Christoph Hellwig
On Tue, Jan 26, 2010 at 07:08:20AM -0600, Anthony Liguori wrote: > >I can either throw in an #ifdef IOV_MAX around the check or fake one up > >for mingw. Does any of the maintainers have a preference for either > >variant? > > > > grep for CONFIG_IOVEC in qemu-common.h and add a #define IOV_MA

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

2010-01-26 Thread Anthony Liguori
On 01/26/2010 03:21 AM, Christoph Hellwig wrote: On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote: To underline that it's a backend/platform dependent thing: Your patch breaks the mingw build for me. Actually that's because mingw is the usual piece of crap and doesn't actual

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

2010-01-26 Thread Christoph Hellwig
On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote: > To underline that it's a backend/platform dependent thing: Your patch > breaks the mingw build for me. Actually that's because mingw is the usual piece of crap and doesn't actually have any of the vector support you can expect from a no

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

2010-01-20 Thread Kevin Wolf
Am 20.01.2010 17:24, schrieb Christoph Hellwig: > On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote: >> Am 19.01.2010 22:15, schrieb Christoph Hellwig: >>> If we go over the maximum number of iovecs support by syscall we get >>> back EINVAL from the kernel which translate to I/O errors for

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

2010-01-20 Thread Christoph Hellwig
On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote: > Am 19.01.2010 22:15, schrieb Christoph Hellwig: > > If we go over the maximum number of iovecs support by syscall we get > > back EINVAL from the kernel which translate to I/O errors for the guest. > > > > Signed-off-by: Christoph Hellw

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

2010-01-20 Thread Anthony Liguori
On 01/19/2010 03:15 PM, Christoph Hellwig wrote: If we go over the maximum number of iovecs support by syscall we get back EINVAL from the kernel which translate to I/O errors for the guest. Signed-off-by: Christoph Hellwig Applied. Thanks. Regards, Anthony Liguori Index: qemu/block.c

Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

2010-01-20 Thread Kevin Wolf
Am 19.01.2010 22:15, schrieb Christoph Hellwig: > If we go over the maximum number of iovecs support by syscall we get > back EINVAL from the kernel which translate to I/O errors for the guest. > > Signed-off-by: Christoph Hellwig Is this really enough? We don't check for IOV_MAX in any other pl

[Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating too large iovecs

2010-01-19 Thread Christoph Hellwig
If we go over the maximum number of iovecs support by syscall we get back EINVAL from the kernel which translate to I/O errors for the guest. Signed-off-by: Christoph Hellwig Index: qemu/block.c === --- qemu.orig/block.c 2010-01-1