Re: [Qemu-devel] [PATCH] block: simplify bdrv_drop_intermediate

2013-10-12 Thread Jeff Cody
On Sat, Oct 12, 2013 at 02:05:45PM +0800, Fam Zheng wrote: > There is only one failure point: bdrv_change_backing_file in this > function, so we can drop the qlist and try to change the backing file > before deleting anything. > > This way bdrv_drop_intermediate is simplified while keeping the > o

[Qemu-devel] [PATCH] block: simplify bdrv_drop_intermediate

2013-10-11 Thread Fam Zheng
There is only one failure point: bdrv_change_backing_file in this function, so we can drop the qlist and try to change the backing file before deleting anything. This way bdrv_drop_intermediate is simplified while keeping the operation transactional. A bonus is dropping an active BDS is supported