Re: [Qemu-devel] [PATCH] block: use correct filename

2013-10-07 Thread Stefan Hajnoczi
On Thu, Oct 03, 2013 at 01:31:27AM +0800, Dunrong Huang wrote: > The content filename point to may be erased by qemu_opts_absorb_qdict() > in raw_open_common() in drv->bdrv_file_open() > > So it's better to use bs->filename. > > Signed-off-by: Dunrong Huang > --- > block.c | 4 ++-- > 1 file ch

Re: [Qemu-devel] [PATCH] block: use correct filename

2013-10-04 Thread Max Reitz
On 2013-10-02 19:31, Dunrong Huang wrote: The content filename point to may be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open() So it's better to use bs->filename. Signed-off-by: Dunrong Huang --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[Qemu-devel] [PATCH] block: use correct filename

2013-10-02 Thread Dunrong Huang
The content filename point to may be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open() So it's better to use bs->filename. Signed-off-by: Dunrong Huang --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 93e1

Re: [Qemu-devel] [PATCH] block: use correct filename for error report

2013-10-02 Thread Dunrong Huang
On Wed, Oct 2, 2013 at 5:48 PM, Stefan Hajnoczi wrote: > On Tue, Sep 24, 2013 at 06:14:01PM +0800, Dunrong Huang wrote: > > The content filename point to will be erased by qemu_opts_absorb_qdict() > > in raw_open_common() in drv->bdrv_file_open() > > > > So it's better to use bs->filename. > > >

Re: [Qemu-devel] [PATCH] block: use correct filename for error report

2013-10-02 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 06:14:01PM +0800, Dunrong Huang wrote: > The content filename point to will be erased by qemu_opts_absorb_qdict() > in raw_open_common() in drv->bdrv_file_open() > > So it's better to use bs->filename. > > Signed-off-by: Dunrong Huang > --- > block.c | 4 ++-- > 1 file c

Re: [Qemu-devel] [PATCH] block: use correct filename for error report

2013-09-30 Thread Dunrong Huang
ping? On Tue, Sep 24, 2013 at 8:12 PM, Max Reitz wrote: > On 2013-09-24 12:14, Dunrong Huang wrote: > >> The content filename point to will be erased by qemu_opts_absorb_qdict() >> in raw_open_common() in drv->bdrv_file_open() >> >> So it's better to use bs->filename. >> >> Signed-off-by: Dunro

Re: [Qemu-devel] [PATCH] block: use correct filename for error report

2013-09-24 Thread Max Reitz
On 2013-09-24 12:14, Dunrong Huang wrote: The content filename point to will be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open() So it's better to use bs->filename. Signed-off-by: Dunrong Huang --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[Qemu-devel] [PATCH] block: use correct filename for error report

2013-09-24 Thread Dunrong Huang
The content filename point to will be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv->bdrv_file_open() So it's better to use bs->filename. Signed-off-by: Dunrong Huang --- block.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index ea4