Re: [Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation

2014-09-19 Thread Stefan Hajnoczi
On Tue, Sep 16, 2014 at 03:12:06PM -0400, Jeff Cody wrote: > In vhdx_create_metadata(), we allocate 40 bytes to entry_buffer for > the various metadata table entries. However, we write out 64kB from > that buffer into the new file. Only write out the correct 40 bytes. > > Signed-off-by: Jeff Cod

Re: [Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation

2014-09-18 Thread Markus Armbruster
Markus Armbruster writes: > Jeff Cody writes: > >> On Wed, Sep 17, 2014 at 08:33:10AM +0200, Markus Armbruster wrote: >>> Jeff Cody writes: >>> >>> > In vhdx_create_metadata(), we allocate 40 bytes to entry_buffer for >>> > the various metadata table entries. However, we write out 64kB from >

Re: [Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation

2014-09-17 Thread Markus Armbruster
Jeff Cody writes: > On Wed, Sep 17, 2014 at 08:33:10AM +0200, Markus Armbruster wrote: >> Jeff Cody writes: >> >> > In vhdx_create_metadata(), we allocate 40 bytes to entry_buffer for >> > the various metadata table entries. However, we write out 64kB from >> > that buffer into the new file.

Re: [Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation

2014-09-17 Thread Jeff Cody
On Wed, Sep 17, 2014 at 08:33:10AM +0200, Markus Armbruster wrote: > Jeff Cody writes: > > > In vhdx_create_metadata(), we allocate 40 bytes to entry_buffer for > > the various metadata table entries. However, we write out 64kB from > > that buffer into the new file. Only write out the correct

Re: [Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation

2014-09-16 Thread Markus Armbruster
Jeff Cody writes: > In vhdx_create_metadata(), we allocate 40 bytes to entry_buffer for > the various metadata table entries. However, we write out 64kB from > that buffer into the new file. Only write out the correct 40 bytes. > > Signed-off-by: Jeff Cody > --- > block/vhdx.c | 16 --

[Qemu-devel] [PATCH] block: vhdx - fix reading beyond pointer during image creation

2014-09-16 Thread Jeff Cody
In vhdx_create_metadata(), we allocate 40 bytes to entry_buffer for the various metadata table entries. However, we write out 64kB from that buffer into the new file. Only write out the correct 40 bytes. Signed-off-by: Jeff Cody --- block/vhdx.c | 16 1 file changed, 8 inserti