Re: [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del

2015-06-25 Thread Paolo Bonzini
Ping? Paolo On 28/05/2015 16:17, Paolo Bonzini wrote: > bdrv_close already does that, and in fact hmp_drive_del would need > another drain after the flush (which bdrv_close does). So remove > the duplication. > > Signed-off-by: Paolo Bonzini > --- > blockdev.c | 3 --- > 1 file changed, 3 del

Re: [Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del

2015-05-28 Thread Fam Zheng
- Original Message - > bdrv_close already does that, and in fact hmp_drive_del would need > another drain after the flush (which bdrv_close does). So remove > the duplication. > > Signed-off-by: Paolo Bonzini Reviewed-by: Fam Zheng > --- > blockdev.c | 3 --- > 1 file changed, 3 de

[Qemu-devel] [PATCH] blockdev: no need to drain+flush in hmp_drive_del

2015-05-28 Thread Paolo Bonzini
bdrv_close already does that, and in fact hmp_drive_del would need another drain after the flush (which bdrv_close does). So remove the duplication. Signed-off-by: Paolo Bonzini --- blockdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5eaf77e..d506a70 1