Re: [Qemu-devel] [PATCH] bugfix: passing reference instead of value

On Mon, Dec 28, 2015 at 10:54:23AM +0800, Cao jin wrote: > Fix the bug introduced by 595a4f07. Function host_pci_config_read() should be > passed by a reference, not a value, for the later pci_default_write_config(). What's the effect of the bug? Does it break igd assignment? How come it worked

Re: [Qemu-devel] [PATCH] bugfix: passing reference instead of value

BTW, I send the v2 version of this patch, the changelog of v2 is: ensure the value writen into register of pci config space is always little endian, using cpu_to_le32(). So, the actual change by v2 is following: -pci_default_write_config(pci_dev, pos, val, len); +

Re: [Qemu-devel] [PATCH] bugfix: passing reference instead of value

On 12/28/2015 07:50 PM, Michael S. Tsirkin wrote: On Mon, Dec 28, 2015 at 10:54:23AM +0800, Cao jin wrote: Fix the bug introduced by 595a4f07. Function host_pci_config_read() should be passed by a reference, not a value, for the later pci_default_write_config(). What's the effect of the

[Qemu-devel] [PATCH] bugfix: passing reference instead of value

Fix the bug introduced by 595a4f07. Function host_pci_config_read() should be passed by a reference, not a value, for the later pci_default_write_config(). Signed-off-by: Cao jin --- Separated from previous "igd-passthru convert to realize" patch. Since these two don`t