Re: [Qemu-devel] [PATCH] build: Don't redefine 'inline'

2016-02-16 Thread Peter Maydell
On 9 February 2016 at 18:49, Eric Blake wrote: > Actively redefining 'inline' is wrong for C++, where gcc has an > extension 'inline namespace' which fails to compile if the > keyword 'inline' is replaced by a macro expansion. This will > matter once we start to include "qemu/osdep.h" first from

Re: [Qemu-devel] [PATCH] build: Don't redefine 'inline'

2016-02-12 Thread Eric Blake
On 02/12/2016 06:24 AM, Peter Maydell wrote: > On 9 February 2016 at 18:49, Eric Blake wrote: >> Actively redefining 'inline' is wrong for C++, where gcc has an >> extension 'inline namespace' which fails to compile if the >> keyword 'inline' is replaced by a macro expansion. This will >> matter

Re: [Qemu-devel] [PATCH] build: Don't redefine 'inline'

2016-02-12 Thread Peter Maydell
On 9 February 2016 at 18:49, Eric Blake wrote: > Actively redefining 'inline' is wrong for C++, where gcc has an > extension 'inline namespace' which fails to compile if the > keyword 'inline' is replaced by a macro expansion. This will > matter once we start to include "qemu/osdep.h" first from

[Qemu-devel] [PATCH] build: Don't redefine 'inline'

2016-02-09 Thread Eric Blake
Actively redefining 'inline' is wrong for C++, where gcc has an extension 'inline namespace' which fails to compile if the keyword 'inline' is replaced by a macro expansion. This will matter once we start to include "qemu/osdep.h" first from C++ files, depending also on whether the system headers