Re: [Qemu-devel] [PATCH] char: don't exit on hmp 'chardev-add help'

2017-07-24 Thread Paolo Bonzini
On 17/07/2017 12:52, Anton Nefedov wrote: > qemu_chr_new_from_opts() is used from both vl.c and hmp, > and it is quite confusing to see qemu suddenly exit after receiving a help > option in hmp. > > Create a separate function for printing help and let different callers > react accordingly. > > Si

Re: [Qemu-devel] [PATCH] char: don't exit on hmp 'chardev-add help'

2017-07-17 Thread Marc-André Lureau
Hi On Mon, Jul 17, 2017 at 12:56 PM Anton Nefedov wrote: > qemu_chr_new_from_opts() is used from both vl.c and hmp, > and it is quite confusing to see qemu suddenly exit after receiving a help > option in hmp. > > Create a separate function for printing help and let different callers > react acc

[Qemu-devel] [PATCH] char: don't exit on hmp 'chardev-add help'

2017-07-17 Thread Anton Nefedov
qemu_chr_new_from_opts() is used from both vl.c and hmp, and it is quite confusing to see qemu suddenly exit after receiving a help option in hmp. Create a separate function for printing help and let different callers react accordingly. Signed-off-by: Anton Nefedov --- include/chardev/char.h |