Re: [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-17 Thread Andrey Shinkevich
On 16/07/2019 17:24, Paolo Bonzini wrote: > On 16/07/19 15:08, Andrey Shinkevich wrote: >> The test check-qtest-x86_64: tests/qos-test hangs with the >> QTEST_VHOST_USER_FIXME set even without applying the series: > > Hmm it must have bitrot. :(( I hope I can look at it on Thursday. > > Paolo

Re: [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-17 Thread Andrey Shinkevich
On 15/07/2019 21:27, Paolo Bonzini wrote: > On 15/07/19 19:23, Max Reitz wrote: >> On 12.07.19 21:17, Andrey Shinkevich wrote: >>> When tcp_chr_disconnect() is called, other thread may be still writing >>> to the channel. This patch protects only read operations that initiate >>> the disconnectio

Re: [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-16 Thread Paolo Bonzini
On 16/07/19 15:08, Andrey Shinkevich wrote: > The test check-qtest-x86_64: tests/qos-test hangs with the > QTEST_VHOST_USER_FIXME set even without applying the series: Hmm it must have bitrot. :(( I hope I can look at it on Thursday. Paolo

Re: [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-16 Thread Andrey Shinkevich
On 15/07/2019 21:27, Paolo Bonzini wrote: > On 15/07/19 19:23, Max Reitz wrote: >> On 12.07.19 21:17, Andrey Shinkevich wrote: >>> When tcp_chr_disconnect() is called, other thread may be still writing >>> to the channel. This patch protects only read operations that initiate >>> the disconnectio

Re: [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-16 Thread Andrey Shinkevich
On 15/07/2019 20:23, Max Reitz wrote: > On 12.07.19 21:17, Andrey Shinkevich wrote: >> When tcp_chr_disconnect() is called, other thread may be still writing >> to the channel. This patch protects only read operations that initiate >> the disconnection. >> >> Signed-off-by: Andrey Shinkevich >>

Re: [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-16 Thread Max Reitz
On 15.07.19 20:27, Paolo Bonzini wrote: > On 15/07/19 19:23, Max Reitz wrote: >> On 12.07.19 21:17, Andrey Shinkevich wrote: >>> When tcp_chr_disconnect() is called, other thread may be still writing >>> to the channel. This patch protects only read operations that initiate >>> the disconnection. >

Re: [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-15 Thread Paolo Bonzini
On 15/07/19 19:23, Max Reitz wrote: > On 12.07.19 21:17, Andrey Shinkevich wrote: >> When tcp_chr_disconnect() is called, other thread may be still writing >> to the channel. This patch protects only read operations that initiate >> the disconnection. >> >> Signed-off-by: Andrey Shinkevich >> ---

Re: [Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-15 Thread Max Reitz
On 12.07.19 21:17, Andrey Shinkevich wrote: > When tcp_chr_disconnect() is called, other thread may be still writing > to the channel. This patch protects only read operations that initiate > the disconnection. > > Signed-off-by: Andrey Shinkevich > --- Have you looked at https://lists.nongnu.or

[Qemu-devel] [PATCH] chardev: race condition with tcp_chr_disconnect

2019-07-12 Thread Andrey Shinkevich
When tcp_chr_disconnect() is called, other thread may be still writing to the channel. This patch protects only read operations that initiate the disconnection. Signed-off-by: Andrey Shinkevich --- The segmentation fault occurred because of the race condition when the write operation was interrup