Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Markus Armbruster
Laszlo Ersek writes: > On 07/23/12 17:01, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> On 07/23/12 14:46, Markus Armbruster wrote: Laszlo Ersek writes: > Signed-off-by: Laszlo Ersek > --- > hw/qdev.c | 14 +- > vl.c |7 ++- >

Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Laszlo Ersek
On 07/23/12 17:01, Markus Armbruster wrote: > Laszlo Ersek writes: > >> On 07/23/12 14:46, Markus Armbruster wrote: >>> Laszlo Ersek writes: >>> Signed-off-by: Laszlo Ersek --- hw/qdev.c | 14 +- vl.c |7 ++- 2 files changed, 19 insertions(+)

Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Markus Armbruster
Laszlo Ersek writes: > On 07/23/12 14:46, Markus Armbruster wrote: >> Laszlo Ersek writes: >> >>> Signed-off-by: Laszlo Ersek >>> --- >>> hw/qdev.c | 14 +- >>> vl.c |7 ++- >>> 2 files changed, 19 insertions(+), 2 deletions(-) >>> >>> diff --git a/hw/qdev.c b/hw/qd

Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Markus Armbruster
Laszlo Ersek writes: > Signed-off-by: Laszlo Ersek > --- > hw/qdev.c | 14 +- > vl.c |7 ++- > 2 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/hw/qdev.c b/hw/qdev.c > index af54467..f1e83a4 100644 > --- a/hw/qdev.c > +++ b/hw/qdev.c > @@ -502,6 +502

Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Laszlo Ersek
On 07/23/12 14:46, Markus Armbruster wrote: > Laszlo Ersek writes: > >> Signed-off-by: Laszlo Ersek >> --- >> hw/qdev.c | 14 +- >> vl.c |7 ++- >> 2 files changed, 19 insertions(+), 2 deletions(-) >> >> diff --git a/hw/qdev.c b/hw/qdev.c >> index af54467..f1e83a4 100

Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Peter Maydell
On 23 July 2012 13:34, Peter Maydell wrote: > On 23 July 2012 12:33, Laszlo Ersek wrote: >> >> Signed-off-by: Laszlo Ersek > > I think it would be much nicer to just rewrite qdev_get_fw_dev_path > so we weren't trying to fill the path into a fixed string buffer > at all. Here is an entirely unte

Re: [Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Peter Maydell
On 23 July 2012 12:33, Laszlo Ersek wrote: > > Signed-off-by: Laszlo Ersek I think it would be much nicer to just rewrite qdev_get_fw_dev_path so we weren't trying to fill the path into a fixed string buffer at all. Here is an entirely untested implementation: char *qdev_get_fw_dev_path(DeviceS

[Qemu-devel] [PATCH] check for available room when formatting OpenFirmware device path

2012-07-23 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- hw/qdev.c | 14 +- vl.c |7 ++- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index af54467..f1e83a4 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -502,6 +502,10 @@ static int qdev_get_fw_dev_path_help