On 02/18/2012 08:53 AM, Andreas Färber wrote:
>> I think only 'git blame' output would be affected and that is not 100%
>> reliable anyway, considering for example code movement.
>
> I use repo.or.cz's blame function quite often to find out who to cc or
> what commit to mention, and (valid) typo
Am 18.02.2012 10:13, schrieb Blue Swirl:
> One way to handle this is gradual reformatting, every time when code
> is touched, only changes towards common CODING_STYLE are allowed.
That's what we've been doing wrt braces and I appreciate us not
cluttering the history with reformatting commits.
Esp
On Sat, Feb 18, 2012 at 14:18, Anthony Liguori wrote:
> On 02/18/2012 04:56 AM, Stefan Weil wrote:
>>
>> Am 18.02.2012 10:13, schrieb Blue Swirl:
>>>
>>> On Fri, Feb 17, 2012 at 15:26, Anthony Liguori
>>> wrote:
Well this was what I was getting at in my previous comments. If we just
>>>
On 02/18/2012 04:56 AM, Stefan Weil wrote:
Am 18.02.2012 10:13, schrieb Blue Swirl:
On Fri, Feb 17, 2012 at 15:26, Anthony Liguori wrote:
Well this was what I was getting at in my previous comments. If we just
need to reindent < 10 files with a few random changes here and there, then
maybe tha
Am 18.02.2012 10:13, schrieb Blue Swirl:
On Fri, Feb 17, 2012 at 15:26, Anthony Liguori
wrote:
Well this was what I was getting at in my previous comments. If we just
need to reindent < 10 files with a few random changes here and there,
then
maybe that isn't so bad.
But if we have to touch
On Fri, Feb 17, 2012 at 15:26, Anthony Liguori wrote:
> On 02/17/2012 08:55 AM, Markus Armbruster wrote:
>>
>> Anthony Liguori writes:
>>
>>> I really hate having these discussions. I would almost rather we just
>>> pay the one-time cost of re-indenting so we can stop debating about
>>> this.
>>
On Fri, Feb 17, 2012 at 14:31, Anthony Liguori wrote:
> On 02/11/2012 03:44 AM, Blue Swirl wrote:
>>
>> On Fri, Feb 10, 2012 at 17:47, Anthony Liguori
>> wrote:
>>>
>>> On 02/09/2012 10:02 PM, malc wrote:
On Fri, 10 Feb 2012, Evgeny Voevodin wrote:
> On 02/09/2012 06:59 PM
On 02/17/2012 08:55 AM, Markus Armbruster wrote:
Anthony Liguori writes:
I really hate having these discussions. I would almost rather we just
pay the one-time cost of re-indenting so we can stop debating about
this.
For folks that feel strongly about this, please submit the following:
An i
Anthony Liguori writes:
> I really hate having these discussions. I would almost rather we just
> pay the one-time cost of re-indenting so we can stop debating about
> this.
>
> For folks that feel strongly about this, please submit the following:
>
> An indent command that takes the tree to COD
On 02/11/2012 03:44 AM, Blue Swirl wrote:
On Fri, Feb 10, 2012 at 17:47, Anthony Liguori wrote:
On 02/09/2012 10:02 PM, malc wrote:
On Fri, 10 Feb 2012, Evgeny Voevodin wrote:
On 02/09/2012 06:59 PM, Andreas F?rber wrote:
Disable warnings for spaces before opening parenthesis in
hw/{ac97,
On Fri, Feb 10, 2012 at 17:47, Anthony Liguori wrote:
> On 02/09/2012 10:02 PM, malc wrote:
>>
>> On Fri, 10 Feb 2012, Evgeny Voevodin wrote:
>>
>>> On 02/09/2012 06:59 PM, Andreas F?rber wrote:
Disable warnings for spaces before opening parenthesis in
hw/{ac97,adlib,cs4231a,es1370,
On Thu, Feb 9, 2012 at 14:59, Andreas Färber wrote:
> Disable warnings for spaces before opening parenthesis in
> hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
>
> Signed-off-by: Andreas Färber
> Cc: Blue Swirl
> Cc: malc
> ---
> scripts/checkpatch.pl | 5 +
> 1 files changed, 5 insertions
On 02/09/2012 10:02 PM, malc wrote:
On Fri, 10 Feb 2012, Evgeny Voevodin wrote:
On 02/09/2012 06:59 PM, Andreas F?rber wrote:
Disable warnings for spaces before opening parenthesis in
hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
Why audio files are such a special thing?
Because they are cons
On Fri, 10 Feb 2012, Evgeny Voevodin wrote:
> On 02/09/2012 06:59 PM, Andreas F?rber wrote:
> > Disable warnings for spaces before opening parenthesis in
> > hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
>
> Why audio files are such a special thing?
Because they are consistently formatted the way t
On 02/09/2012 06:59 PM, Andreas Färber wrote:
Disable warnings for spaces before opening parenthesis in
hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
Why audio files are such a special thing?
Isn't it be better to revert a patch that introduced checkpatch.pl errors?
--
Kind regards,
Evgeny Voevod
On Thu, 9 Feb 2012, Andreas F?rber wrote:
> Disable warnings for spaces before opening parenthesis in
> hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
>
> Signed-off-by: Andreas F?rber
> Cc: Blue Swirl
> Cc: malc
Thanks.
> ---
> scripts/checkpatch.pl |5 +
> 1 files changed, 5 insertion
Am 09.02.2012 15:59, schrieb Andreas Färber:
> Disable warnings for spaces before opening parenthesis in
> hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
>
> Signed-off-by: Andreas Färber
> Cc: Blue Swirl
> Cc: malc
> ---
For testing I used the following pseudo-patch:
--8<--
--- a/hw/sb16.c
+++
Disable warnings for spaces before opening parenthesis in
hw/{ac97,adlib,cs4231a,es1370,gus,sb16}.c.
Signed-off-by: Andreas Färber
Cc: Blue Swirl
Cc: malc
---
scripts/checkpatch.pl |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/chec
18 matches
Mail list logo
