Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-27 Thread Riku Voipio
On 27 September 2016 at 14:58, Paolo Bonzini wrote: > > > On 26/09/2016 21:58, riku.voi...@linaro.org wrote: >> From: Riku Voipio >> >> Linux-user and bsd-user code needs lots of arch-specific ifdefs, >> so disable the warning. >> >> Signed-off-by: Riku Voipio >> --- >> scripts/checkpatch.pl |

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-27 Thread Paolo Bonzini
On 26/09/2016 21:58, riku.voi...@linaro.org wrote: > From: Riku Voipio > > Linux-user and bsd-user code needs lots of arch-specific ifdefs, > so disable the warning. > > Signed-off-by: Riku Voipio > --- > scripts/checkpatch.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-26 Thread Peter Maydell
On 26 September 2016 at 16:36, Riku Voipio wrote: > On 27 September 2016 at 00:08, Peter Maydell wrote: >> Do you have some examples of the false positives you want >> to suppress here? For new code I would hope that we can >> handle host-arch-specifics by having new files (or just >> new #define

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-26 Thread Riku Voipio
On 27 September 2016 at 00:08, Peter Maydell wrote: > On 26 September 2016 at 12:58, wrote: >> From: Riku Voipio >> >> Linux-user and bsd-user code needs lots of arch-specific ifdefs, >> so disable the warning. >> >> Signed-off-by: Riku Voipio >> --- >> scripts/checkpatch.pl | 5 +++-- >> 1 f

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-26 Thread Peter Maydell
On 26 September 2016 at 12:58, wrote: > From: Riku Voipio > > Linux-user and bsd-user code needs lots of arch-specific ifdefs, > so disable the warning. > > Signed-off-by: Riku Voipio > --- > scripts/checkpatch.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/sc

Re: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-26 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1474919934-21518-1-git-send-email-riku.voi...@linaro.org Subject: [Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user === TEST SCRIPT BEGIN

[Qemu-devel] [PATCH] checkpatch.pl: disable arch-specific test for linux-user

2016-09-26 Thread riku . voipio
From: Riku Voipio Linux-user and bsd-user code needs lots of arch-specific ifdefs, so disable the warning. Signed-off-by: Riku Voipio --- scripts/checkpatch.pl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index dde3f5f..