[Qemu-devel] [PATCH] cmd: Fix potential memory leak

[Pavel Borzenkov]

Signed-off-by: Pavel Borzenkov <pavel.borzen...@gmail.com>
---
Note, that almost all code in the file violates CODING STYLE. The changed lines
are written wrt CODING STYLE (like commits 7d7d975c and c32d766a).
---
 cmd.c |   11 ++++++++---
 1 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/cmd.c b/cmd.c
index abcf206..e1ae5a0 100644
--- a/cmd.c
+++ b/cmd.c
@@ -334,16 +334,21 @@ breakline(
        int     c = 0;
        char    *p;
        char    **rval = calloc(sizeof(char *), 1);
+    char **tmp;
 
        while (rval && (p = qemu_strsep(&input, " ")) != NULL) {
                if (!*p)
                        continue;
                c++;
-               rval = realloc(rval, sizeof(*rval) * (c + 1));
-               if (!rval) {
+        tmp = realloc(rval, sizeof(*rval) * (c + 1));
+        if (!tmp) {
+            free(rval);
+            rval = NULL;
                        c = 0;
                        break;
-               }
+        } else {
+            rval = tmp;
+        }
                rval[c - 1] = p;
                rval[c] = NULL;
        }
-- 
1.7.0.4