Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-07 Thread Eduardo Habkost
On Mon, Jan 07, 2019 at 09:12:06AM +0100, Cornelia Huck wrote: > On Fri, 4 Jan 2019 20:00:50 -0200 > Eduardo Habkost wrote: > > > On Fri, Jan 04, 2019 at 04:13:15PM -0500, Michael S. Tsirkin wrote: > > > On Fri, Jan 04, 2019 at 07:06:56PM -0200, Eduardo Habkost wrote: > > > > On Fri, Jan 04,

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-07 Thread Cornelia Huck
On Fri, 4 Jan 2019 20:00:50 -0200 Eduardo Habkost wrote: > On Fri, Jan 04, 2019 at 04:13:15PM -0500, Michael S. Tsirkin wrote: > > On Fri, Jan 04, 2019 at 07:06:56PM -0200, Eduardo Habkost wrote: > > > On Fri, Jan 04, 2019 at 03:48:02PM -0500, Michael S. Tsirkin wrote: > > > > On Fri, Jan

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2019 at 04:13:15PM -0500, Michael S. Tsirkin wrote: > On Fri, Jan 04, 2019 at 07:06:56PM -0200, Eduardo Habkost wrote: > > On Fri, Jan 04, 2019 at 03:48:02PM -0500, Michael S. Tsirkin wrote: > > > On Fri, Jan 04, 2019 at 06:09:52PM -0200, Eduardo Habkost wrote: > > > > On Fri, Jan

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Michael S. Tsirkin
On Fri, Jan 04, 2019 at 07:06:56PM -0200, Eduardo Habkost wrote: > On Fri, Jan 04, 2019 at 03:48:02PM -0500, Michael S. Tsirkin wrote: > > On Fri, Jan 04, 2019 at 06:09:52PM -0200, Eduardo Habkost wrote: > > > On Fri, Jan 04, 2019 at 03:54:39PM -0200, Eduardo Habkost wrote: > > > > On Fri, Jan 04,

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2019 at 03:48:02PM -0500, Michael S. Tsirkin wrote: > On Fri, Jan 04, 2019 at 06:09:52PM -0200, Eduardo Habkost wrote: > > On Fri, Jan 04, 2019 at 03:54:39PM -0200, Eduardo Habkost wrote: > > > On Fri, Jan 04, 2019 at 10:12:00AM +, Dr. David Alan Gilbert wrote: > > > > *

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Michael S. Tsirkin
On Fri, Jan 04, 2019 at 06:09:52PM -0200, Eduardo Habkost wrote: > On Fri, Jan 04, 2019 at 03:54:39PM -0200, Eduardo Habkost wrote: > > On Fri, Jan 04, 2019 at 10:12:00AM +, Dr. David Alan Gilbert wrote: > > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > > On Fri, Jan 04, 2019 at

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2019 at 03:54:39PM -0200, Eduardo Habkost wrote: > On Fri, Jan 04, 2019 at 10:12:00AM +, Dr. David Alan Gilbert wrote: > > * Michael S. Tsirkin (m...@redhat.com) wrote: > > > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote: > > > > The virtio-pci entries in

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2019 at 10:12:00AM +, Dr. David Alan Gilbert wrote: > * Michael S. Tsirkin (m...@redhat.com) wrote: > > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote: > > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > > > assumption: that all virtio-pci

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Eduardo Habkost
On Fri, Jan 04, 2019 at 10:49:19AM +0100, Cornelia Huck wrote: > On Fri, 4 Jan 2019 01:22:26 -0200 > Eduardo Habkost wrote: > > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > > assumption: that all virtio-pci subclasses support the > > disable-legacy and disable-modern options. > >

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Eduardo Habkost
On Thu, Jan 03, 2019 at 11:23:45PM -0500, Michael S. Tsirkin wrote: > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote: > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > > assumption: that all virtio-pci subclasses support the > > disable-legacy and disable-modern

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Dr. David Alan Gilbert
* Michael S. Tsirkin (m...@redhat.com) wrote: > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote: > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > > assumption: that all virtio-pci subclasses support the > > disable-legacy and disable-modern options. > > > > That

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Cornelia Huck
On Fri, 4 Jan 2019 01:22:26 -0200 Eduardo Habkost wrote: > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > assumption: that all virtio-pci subclasses support the > disable-legacy and disable-modern options. > > That assumption was broken by commit f6e501a28ef9 ("virtio: > Provide

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-04 Thread Cornelia Huck
On Thu, 3 Jan 2019 23:23:45 -0500 "Michael S. Tsirkin" wrote: > On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote: > > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > > assumption: that all virtio-pci subclasses support the > > disable-legacy and disable-modern options. >

Re: [Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-03 Thread Michael S. Tsirkin
On Fri, Jan 04, 2019 at 01:22:26AM -0200, Eduardo Habkost wrote: > The virtio-pci entries in HW_COMPAT_2_6 had an implicit > assumption: that all virtio-pci subclasses support the > disable-legacy and disable-modern options. > > That assumption was broken by commit f6e501a28ef9 ("virtio: >

[Qemu-devel] [PATCH] compat: Use explicit type names on HW_COMPAT_2_6

2019-01-03 Thread Eduardo Habkost
The virtio-pci entries in HW_COMPAT_2_6 had an implicit assumption: that all virtio-pci subclasses support the disable-legacy and disable-modern options. That assumption was broken by commit f6e501a28ef9 ("virtio: Provide version-specific variants of virtio PCI devices"). This caused QEMU to