Re: [Qemu-devel] [PATCH] configure: Add a proper check for openpty() in libutil

2019-01-17 Thread Eric Blake
On 1/17/19 12:07 PM, Peter Maydell wrote: > On Thu, 17 Jan 2019 at 17:14, Thomas Huth wrote: >> >> On Linux (and maybe some BSDs), we require libutil for the openpty() >> function. However, this library is not available on some other systems, so >> we currently use a fragile if-statement in the

Re: [Qemu-devel] [PATCH] configure: Add a proper check for openpty() in libutil

2019-01-17 Thread Peter Maydell
On Thu, 17 Jan 2019 at 17:14, Thomas Huth wrote: > > On Linux (and maybe some BSDs), we require libutil for the openpty() > function. However, this library is not available on some other systems, so > we currently use a fragile if-statement in the configure script to check > whether we need the

Re: [Qemu-devel] [PATCH] configure: Add a proper check for openpty() in libutil

2019-01-17 Thread Paolo Bonzini
On 17/01/19 18:14, Thomas Huth wrote: > On Linux (and maybe some BSDs), we require libutil for the openpty() > function. However, this library is not available on some other systems, so > we currently use a fragile if-statement in the configure script to check > whether we need the library or not.

Re: [Qemu-devel] [PATCH] configure: Add a proper check for openpty() in libutil

2019-01-17 Thread Eric Blake
On 1/17/19 11:14 AM, Thomas Huth wrote: > On Linux (and maybe some BSDs), we require libutil for the openpty() > function. However, this library is not available on some other systems, so > we currently use a fragile if-statement in the configure script to check > whether we need the library or

Re: [Qemu-devel] [PATCH] configure: Add a proper check for openpty() in libutil

2019-01-17 Thread Philippe Mathieu-Daudé
On 1/17/19 6:14 PM, Thomas Huth wrote: > On Linux (and maybe some BSDs), we require libutil for the openpty() > function. However, this library is not available on some other systems, so > we currently use a fragile if-statement in the configure script to check > whether we need the library or

[Qemu-devel] [PATCH] configure: Add a proper check for openpty() in libutil

2019-01-17 Thread Thomas Huth
On Linux (and maybe some BSDs), we require libutil for the openpty() function. However, this library is not available on some other systems, so we currently use a fragile if-statement in the configure script to check whether we need the library or not. Unfortunately, we also hard-coded a "-lutil"