Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Thomas Huth
On 2019-01-14 16:23, Thomas Huth wrote: > On 2019-01-14 16:02, Eric Blake wrote: >> On 1/14/19 8:53 AM, Thomas Huth wrote: [...] >>> The patch is only changing libiscsi_cflags, so it's not affecting the >>> entire project, but just the files that use libiscsi. >> >> Even so, limiting the damage to

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Thomas Huth
On 2019-01-14 16:02, Eric Blake wrote: > On 1/14/19 8:53 AM, Thomas Huth wrote: >> On 2019-01-14 15:50, Eric Blake wrote: >>> On 1/14/19 8:31 AM, Daniel P. Berrangé wrote: >>> > > Can we suppress the warnings with #pragma instead ? > That would avoid compiling the .o file with

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Philippe Mathieu-Daudé
On 1/14/19 3:36 PM, Thomas Huth wrote: > On 2019-01-14 15:31, Philippe Mathieu-Daudé wrote: >> On 1/14/19 2:46 PM, Thomas Huth wrote: >>> The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad >>> "inline" prototype definitions which GCC refuses to compile in its >>> gnu99 mode: >>> >>>

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Daniel P . Berrangé
On Mon, Jan 14, 2019 at 03:53:48PM +0100, Thomas Huth wrote: > On 2019-01-14 15:50, Eric Blake wrote: > > On 1/14/19 8:31 AM, Daniel P. Berrangé wrote: > > > >>> > >>> Can we suppress the warnings with #pragma instead ? > >>> That would avoid compiling the .o file with different > >>> C

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Eric Blake
On 1/14/19 8:53 AM, Thomas Huth wrote: > On 2019-01-14 15:50, Eric Blake wrote: >> On 1/14/19 8:31 AM, Daniel P. Berrangé wrote: >> Can we suppress the warnings with #pragma instead ? That would avoid compiling the .o file with different C semantics. >>> >>> IIUC this is a

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Eric Blake
On 1/14/19 8:31 AM, Daniel P. Berrangé wrote: >> >> Can we suppress the warnings with #pragma instead ? >> That would avoid compiling the .o file with different >> C semantics. > > IIUC this is a built-in warning you can't disable, except by changing > the compilation mode to have gnu89 inline

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Philippe Mathieu-Daudé
On 1/14/19 2:46 PM, Thomas Huth wrote: > The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad > "inline" prototype definitions which GCC refuses to compile in its > gnu99 mode: > > In file included from block/iscsi.c:52:0: > /usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Thomas Huth
On 2019-01-14 15:50, Eric Blake wrote: > On 1/14/19 8:31 AM, Daniel P. Berrangé wrote: > >>> >>> Can we suppress the warnings with #pragma instead ? >>> That would avoid compiling the .o file with different >>> C semantics. >> >> IIUC this is a built-in warning you can't disable, except by

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Thomas Huth
On 2019-01-14 15:31, Daniel P. Berrangé wrote: > On Mon, Jan 14, 2019 at 01:52:01PM +, Peter Maydell wrote: >> On Mon, 14 Jan 2019 at 13:47, Thomas Huth wrote: >>> >>> The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad >>> "inline" prototype definitions which GCC refuses to

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Thomas Huth
On 2019-01-14 15:31, Philippe Mathieu-Daudé wrote: > On 1/14/19 2:46 PM, Thomas Huth wrote: >> The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad >> "inline" prototype definitions which GCC refuses to compile in its >> gnu99 mode: >> >> In file included from block/iscsi.c:52:0: >>

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Daniel P . Berrangé
On Mon, Jan 14, 2019 at 01:52:01PM +, Peter Maydell wrote: > On Mon, 14 Jan 2019 at 13:47, Thomas Huth wrote: > > > > The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad > > "inline" prototype definitions which GCC refuses to compile in its > > gnu99 mode: > > > > In file

[Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Thomas Huth
The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad "inline" prototype definitions which GCC refuses to compile in its gnu99 mode: In file included from block/iscsi.c:52:0: /usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function ‘scsi_set_uint16’ declared but never defined

Re: [Qemu-devel] [PATCH] configure: Work-around a bug in libiscsi 1.9.0 when used in gnu99 mode

2019-01-14 Thread Peter Maydell
On Mon, 14 Jan 2019 at 13:47, Thomas Huth wrote: > > The header "scsi-lowlevel.h" of libiscsi 1.9.0 contains some bad > "inline" prototype definitions which GCC refuses to compile in its > gnu99 mode: > > In file included from block/iscsi.c:52:0: > /usr/include/iscsi/scsi-lowlevel.h:810:13: