Re: [Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-08 Thread Paolo Bonzini
On 08/11/2017 18:36, Stefan Hajnoczi wrote: > On Wed, Nov 08, 2017 at 09:57:47AM -0600, Eric Blake wrote: >> On 11/08/2017 09:47 AM, Paolo Bonzini wrote: >>> On 08/11/2017 16:42, Stefan Hajnoczi wrote: > In any case, co_aio_sleep_ns() > + * does not affect the #AioContext where the current

Re: [Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-08 Thread Eric Blake
On 11/08/2017 11:36 AM, Stefan Hajnoczi wrote: >> This function uses timers and hence needs to know the event loop >> (#AioContext) to place the timer on. After the time elapses, the >> current coroutine will restart with the same #AioContext it is currently >> running in, even if that is differe

Re: [Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-08 Thread Stefan Hajnoczi
On Wed, Nov 08, 2017 at 09:57:47AM -0600, Eric Blake wrote: > On 11/08/2017 09:47 AM, Paolo Bonzini wrote: > > On 08/11/2017 16:42, Stefan Hajnoczi wrote: > >>> In any case, co_aio_sleep_ns() > >>> + * does not affect the #AioContext where the current coroutine is > >>> running, > >>> + * as the c

Re: [Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-08 Thread Eric Blake
On 11/08/2017 09:47 AM, Paolo Bonzini wrote: > On 08/11/2017 16:42, Stefan Hajnoczi wrote: >>> In any case, co_aio_sleep_ns() >>> + * does not affect the #AioContext where the current coroutine is running, >>> + * as the coroutine will restart on the same #AioContext that it is >>> + * running on.

Re: [Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-08 Thread Paolo Bonzini
On 08/11/2017 16:42, Stefan Hajnoczi wrote: >> In any case, co_aio_sleep_ns() >> + * does not affect the #AioContext where the current coroutine is running, >> + * as the coroutine will restart on the same #AioContext that it is >> + * running on. > I cannot parse the second sentence. What does "a

Re: [Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-08 Thread Stefan Hajnoczi
On Tue, Nov 07, 2017 at 04:37:08PM -0600, Eric Blake wrote: > co_sleep_ns() was removed in commit 0b9caf9b, leaving behind a > stale comment. Update the documentation to match the current > usage of this function. > > Suggested-by: Paolo Bonzini > Signed-off-by: Eric Blake > --- > include/qemu

Re: [Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-08 Thread Marc-André Lureau
Hi On Tue, Nov 7, 2017 at 11:37 PM, Eric Blake wrote: > co_sleep_ns() was removed in commit 0b9caf9b, leaving behind a > stale comment. Update the documentation to match the current > usage of this function. > > Suggested-by: Paolo Bonzini > Signed-off-by: Eric Blake > --- > include/qemu/coro

[Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-07 Thread Eric Blake
co_sleep_ns() was removed in commit 0b9caf9b, leaving behind a stale comment. Update the documentation to match the current usage of this function. Suggested-by: Paolo Bonzini Signed-off-by: Eric Blake --- include/qemu/coroutine.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) d