Re: [Qemu-devel] [PATCH] cpu: don't allow negative core id

2017-08-03 Thread Igor Mammedov
On Wed, 2 Aug 2017 18:29:33 -0300 Eduardo Habkost wrote: > On Wed, Aug 02, 2017 at 03:50:36PM +0200, Laurent Vivier wrote: > > On 02/08/2017 15:42, Philippe Mathieu-Daudé wrote: > > > Hi Laurent, > > > > > > On Wed, Aug 2, 2017 at 7:32 AM, Laurent Vivier > > > wrote: > > >> With pseries ma

Re: [Qemu-devel] [PATCH] cpu: don't allow negative core id

2017-08-03 Thread Philippe Mathieu-Daudé
On 08/02/2017 06:29 PM, Eduardo Habkost wrote: On Wed, Aug 02, 2017 at 03:50:36PM +0200, Laurent Vivier wrote: On 02/08/2017 15:42, Philippe Mathieu-Daudé wrote: Hi Laurent, On Wed, Aug 2, 2017 at 7:32 AM, Laurent Vivier wrote: With pseries machine type a negative core-id is not managed prop

Re: [Qemu-devel] [PATCH] cpu: don't allow negative core id

2017-08-02 Thread Eduardo Habkost
On Wed, Aug 02, 2017 at 03:50:36PM +0200, Laurent Vivier wrote: > On 02/08/2017 15:42, Philippe Mathieu-Daudé wrote: > > Hi Laurent, > > > > On Wed, Aug 2, 2017 at 7:32 AM, Laurent Vivier wrote: > >> With pseries machine type a negative core-id is not managed properly: > >> -1 gives an inaccurate

Re: [Qemu-devel] [PATCH] cpu: don't allow negative core id

2017-08-02 Thread David Gibson
On Wed, Aug 02, 2017 at 12:32:59PM +0200, Laurent Vivier wrote: > With pseries machine type a negative core-id is not managed properly: > -1 gives an inaccurate error message ("core -1 already populated"), > -2 crashes QEMU (core dump) > > As it seems a negative value is invalid for any architectu

Re: [Qemu-devel] [PATCH] cpu: don't allow negative core id

2017-08-02 Thread Laurent Vivier
On 02/08/2017 15:42, Philippe Mathieu-Daudé wrote: > Hi Laurent, > > On Wed, Aug 2, 2017 at 7:32 AM, Laurent Vivier wrote: >> With pseries machine type a negative core-id is not managed properly: >> -1 gives an inaccurate error message ("core -1 already populated"), >> -2 crashes QEMU (core dump)

Re: [Qemu-devel] [PATCH] cpu: don't allow negative core id

2017-08-02 Thread Philippe Mathieu-Daudé
Hi Laurent, On Wed, Aug 2, 2017 at 7:32 AM, Laurent Vivier wrote: > With pseries machine type a negative core-id is not managed properly: > -1 gives an inaccurate error message ("core -1 already populated"), > -2 crashes QEMU (core dump) > > As it seems a negative value is invalid for any archite

[Qemu-devel] [PATCH] cpu: don't allow negative core id

2017-08-02 Thread Laurent Vivier
With pseries machine type a negative core-id is not managed properly: -1 gives an inaccurate error message ("core -1 already populated"), -2 crashes QEMU (core dump) As it seems a negative value is invalid for any architecture, instead of checking this in spapr_core_pre_plug() I think it's better