Re: [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning page

2016-05-26 Thread Peter Maydell
On 25 May 2016 at 17:37, Sergey Fedorov wrote: > On 16/05/16 17:36, Sergey Fedorov wrote: >> On 16/05/16 16:49, Richard Henderson wrote: >>> On 05/16/2016 06:13 AM, Sergey Fedorov wrote: It is not safe to make a direct jump to a TB spanning two pages in system emulation because the mappi

Re: [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning page

2016-05-25 Thread Sergey Fedorov
On 16/05/16 17:36, Sergey Fedorov wrote: > On 16/05/16 16:49, Richard Henderson wrote: >> On 05/16/2016 06:13 AM, Sergey Fedorov wrote: >>> It is not safe to make a direct jump to a TB spanning two pages in >>> system emulation because the mapping for the second page can get changed >>> but we don'

Re: [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning page

2016-05-16 Thread Max Filippov
On Mon, May 16, 2016 at 04:13:00PM +0300, Sergey Fedorov wrote: > From: Sergey Fedorov > > It is not safe to make a direct jump to a TB spanning two pages in > system emulation because the mapping for the second page can get changed > but we don't take care of direct jumps in this case. > > Howe

Re: [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning page

2016-05-16 Thread Sergey Fedorov
On 16/05/16 16:49, Richard Henderson wrote: > On 05/16/2016 06:13 AM, Sergey Fedorov wrote: >> It is not safe to make a direct jump to a TB spanning two pages in >> system emulation because the mapping for the second page can get changed >> but we don't take care of direct jumps in this case. > We

Re: [Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning page

2016-05-16 Thread Richard Henderson
On 05/16/2016 06:13 AM, Sergey Fedorov wrote: > It is not safe to make a direct jump to a TB spanning two pages in > system emulation because the mapping for the second page can get changed > but we don't take care of direct jumps in this case. We don't? I'm pretty sure that we do... r~

[Qemu-devel] [PATCH] cpu-exec: Fix direct jump to TB spanning page

2016-05-16 Thread Sergey Fedorov
From: Sergey Fedorov It is not safe to make a direct jump to a TB spanning two pages in system emulation because the mapping for the second page can get changed but we don't take care of direct jumps in this case. However in user mode emulation, this is not the case because there's only static a