Re: [Qemu-devel] [PATCH] cpu_physical_memory_sync_dirty_bitmap: Another alignment fix

2018-01-04 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > On 03/01/2018 19:33, Dr. David Alan Gilbert (git) wrote: > > The optimised version operates on 'longs' dealing with (typically) 64 > > pages at a time, replacing the whole long by a 0 and counting the bits. > > If the Ramblock is less than 64bits in

Re: [Qemu-devel] [PATCH] cpu_physical_memory_sync_dirty_bitmap: Another alignment fix

2018-01-03 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > This code has an optimised, word aligned version, and a boring > unaligned version. My commit f70d345 fixed one alignment issue, but > there's another. > > The optimised version

Re: [Qemu-devel] [PATCH] cpu_physical_memory_sync_dirty_bitmap: Another alignment fix

2018-01-03 Thread Paolo Bonzini
On 03/01/2018 19:33, Dr. David Alan Gilbert (git) wrote: > The optimised version operates on 'longs' dealing with (typically) 64 > pages at a time, replacing the whole long by a 0 and counting the bits. > If the Ramblock is less than 64bits in length that long can contain bits > representing two

Re: [Qemu-devel] [PATCH] cpu_physical_memory_sync_dirty_bitmap: Another alignment fix

2018-01-03 Thread Wei Huang
On 01/03/2018 12:33 PM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > This code has an optimised, word aligned version, and a boring > unaligned version. My commit f70d345 fixed one alignment issue, but > there's another. > > The optimised

[Qemu-devel] [PATCH] cpu_physical_memory_sync_dirty_bitmap: Another alignment fix

2018-01-03 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This code has an optimised, word aligned version, and a boring unaligned version. My commit f70d345 fixed one alignment issue, but there's another. The optimised version operates on 'longs' dealing with (typically) 64 pages at a time,