Re: [Qemu-devel] [PATCH] cpus: ignore ESRCH in qemu_cpu_kick_thread()

2019-01-15 Thread Emilio G. Cota
On Tue, Jan 08, 2019 at 00:02:36 +0100, Paolo Bonzini wrote: > On 02/01/19 15:16, Laurent Vivier wrote: > > We can have a race condition between qemu_cpu_kick_thread() and > > qemu_kvm_cpu_thread_fn() when we hotunplug a CPU. In this case, > > qemu_cpu_kick_thread() can try to kick a thread that is

Re: [Qemu-devel] [PATCH] cpus: ignore ESRCH in qemu_cpu_kick_thread()

2019-01-15 Thread Paolo Bonzini
On 15/01/19 17:34, Laurent Vivier wrote: > On 08/01/2019 19:47, Laurent Vivier wrote: >> On 08/01/2019 00:02, Paolo Bonzini wrote: >>> On 02/01/19 15:16, Laurent Vivier wrote: We can have a race condition between qemu_cpu_kick_thread() and qemu_kvm_cpu_thread_fn() when we hotunplug a CPU.

Re: [Qemu-devel] [PATCH] cpus: ignore ESRCH in qemu_cpu_kick_thread()

2019-01-15 Thread Laurent Vivier
On 08/01/2019 19:47, Laurent Vivier wrote: On 08/01/2019 00:02, Paolo Bonzini wrote: On 02/01/19 15:16, Laurent Vivier wrote: We can have a race condition between qemu_cpu_kick_thread() and qemu_kvm_cpu_thread_fn() when we hotunplug a CPU. In this case, qemu_cpu_kick_thread() can try to kick a

Re: [Qemu-devel] [PATCH] cpus: ignore ESRCH in qemu_cpu_kick_thread()

2019-01-08 Thread Laurent Vivier
On 08/01/2019 00:02, Paolo Bonzini wrote: > On 02/01/19 15:16, Laurent Vivier wrote: >> We can have a race condition between qemu_cpu_kick_thread() and >> qemu_kvm_cpu_thread_fn() when we hotunplug a CPU. In this case, >> qemu_cpu_kick_thread() can try to kick a thread that is exiting. >> pthread_k

Re: [Qemu-devel] [PATCH] cpus: ignore ESRCH in qemu_cpu_kick_thread()

2019-01-07 Thread Paolo Bonzini
On 02/01/19 15:16, Laurent Vivier wrote: > We can have a race condition between qemu_cpu_kick_thread() and > qemu_kvm_cpu_thread_fn() when we hotunplug a CPU. In this case, > qemu_cpu_kick_thread() can try to kick a thread that is exiting. > pthread_kill() returns an error and qemu is stopped by an

Re: [Qemu-devel] [PATCH] cpus: ignore ESRCH in qemu_cpu_kick_thread()

2019-01-02 Thread Philippe Mathieu-Daudé
On 1/2/19 3:16 PM, Laurent Vivier wrote: > We can have a race condition between qemu_cpu_kick_thread() and > qemu_kvm_cpu_thread_fn() when we hotunplug a CPU. In this case, > qemu_cpu_kick_thread() can try to kick a thread that is exiting. > pthread_kill() returns an error and qemu is stopped by an

[Qemu-devel] [PATCH] cpus: ignore ESRCH in qemu_cpu_kick_thread()

2019-01-02 Thread Laurent Vivier
We can have a race condition between qemu_cpu_kick_thread() and qemu_kvm_cpu_thread_fn() when we hotunplug a CPU. In this case, qemu_cpu_kick_thread() can try to kick a thread that is exiting. pthread_kill() returns an error and qemu is stopped by an exit(1). qemu:qemu_cpu_kick_thread: No such