Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-14 Thread Blue Swirl
On Mon, Jul 9, 2012 at 10:27 AM, Peter Maydell wrote: > Ping? [patchwork url http://patchwork.ozlabs.org/patch/167132/] Thanks, applied. > > -- PMM > > On 25 June 2012 15:55, Peter Maydell wrote: >> In our disassembly code, the bfd_vma type is always 64 bits, >> even if the target's virtual add

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Andreas Färber
Am 09.07.2012 15:26, schrieb Peter Maydell: > On 9 July 2012 14:19, Andreas Färber wrote: >> Am 25.06.2012 16:55, schrieb Peter Maydell: >>> In our disassembly code, the bfd_vma type is always 64 bits, >>> even if the target's virtual address width is only 32 bits. This >>> means that when we prin

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Peter Maydell
On 9 July 2012 14:19, Andreas Färber wrote: > Am 25.06.2012 16:55, schrieb Peter Maydell: >> In our disassembly code, the bfd_vma type is always 64 bits, >> even if the target's virtual address width is only 32 bits. This >> means that when we print out addresses we need to truncate them >> to 32

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Andreas Färber
Am 25.06.2012 16:55, schrieb Peter Maydell: > In our disassembly code, the bfd_vma type is always 64 bits, > even if the target's virtual address width is only 32 bits. This > means that when we print out addresses we need to truncate them > to 32 bits, to avoid odd output which has incorrectly sig

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Peter Maydell
On 9 July 2012 13:45, Andreas Färber wrote: > Am 09.07.2012 12:27, schrieb Peter Maydell: >> On 25 June 2012 15:55, Peter Maydell wrote: >>> In our disassembly code, the bfd_vma type is always 64 bits, >>> even if the target's virtual address width is only 32 bits. This >>> means that when we pri

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Andreas Färber
Am 09.07.2012 12:27, schrieb Peter Maydell: > Ping? [patchwork url http://patchwork.ozlabs.org/patch/167132/] > > -- PMM > > On 25 June 2012 15:55, Peter Maydell wrote: >> In our disassembly code, the bfd_vma type is always 64 bits, >> even if the target's virtual address width is only 32 bits.

Re: [Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-07-09 Thread Peter Maydell
Ping? [patchwork url http://patchwork.ozlabs.org/patch/167132/] -- PMM On 25 June 2012 15:55, Peter Maydell wrote: > In our disassembly code, the bfd_vma type is always 64 bits, > even if the target's virtual address width is only 32 bits. This > means that when we print out addresses we need to

[Qemu-devel] [PATCH] disas: Fix printing of addresses in disassembly

2012-06-25 Thread Peter Maydell
In our disassembly code, the bfd_vma type is always 64 bits, even if the target's virtual address width is only 32 bits. This means that when we print out addresses we need to truncate them to 32 bits, to avoid odd output which has incorrectly sign-extended a value to 64 bits, for instance this ARM