[Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-01 Thread Eduardo Otubo
When used with the following command line: ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 QEMU with machine type 40p already creates the device i82374. If specified in the command line, it will try to create it again, hence generating the error. One way to avoid this

[Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Eduardo Otubo
QEMU fails when used with the following command line: ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed. Aborted (core dumped) The 40p machine type already creates

[Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2018-03-26 Thread Eduardo Otubo
QEMU fails when used with the following command line: ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion `!bus->dma[0] && !bus->dma[1]' failed. Aborted (core dumped) The 40p machine type already c

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-01 Thread Eduardo Habkost
i82374 is compiled in only on ppc and sh4, so I'm CCing the maintainers for those architectures. On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote: > When used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > > QEMU wi

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-01 Thread Markus Armbruster
Eduardo Habkost writes: > i82374 is compiled in only on ppc and sh4, so I'm CCing the > maintainers for those architectures. > > On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote: >> When used with the following command line: >> >> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,a

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-01 Thread Eduardo Habkost
On Fri, Sep 01, 2017 at 05:34:34PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > i82374 is compiled in only on ppc and sh4, so I'm CCing the > > maintainers for those architectures. > > > > On Fri, Sep 01, 2017 at 01:03:32PM +0200, Eduardo Otubo wrote: > >> When used with the fo

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-02 Thread Aurelien Jarno
On 2017-09-01 11:30, Eduardo Habkost wrote: > i82374 is compiled in only on ppc and sh4, so I'm CCing the > maintainers for those architectures. The i82374 device is not useful nor usable on SH4. It has just been added in commit 85d3846a39 to be able to run the tests. Aurelien -- Aurelien Jarno

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Paolo Bonzini
On 15/09/2017 11:06, Eduardo Otubo wrote: > QEMU fails when used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion > `!bus->dma[0] && !bus->dma[1]' failed. > Abort

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Eduardo Otubo
On Fri, Sep 15, 2017 at 12:18:11PM +0200, Paolo Bonzini wrote: > On 15/09/2017 11:06, Eduardo Otubo wrote: > > QEMU fails when used with the following command line: > > > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > > qemu-system-ppc64: hw/isa/isa-bus.c:110: i

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-15 Thread Eduardo Habkost
On Fri, Sep 15, 2017 at 12:18:11PM +0200, Paolo Bonzini wrote: > On 15/09/2017 11:06, Eduardo Otubo wrote: > > QEMU fails when used with the following command line: > > > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > > qemu-system-ppc64: hw/isa/isa-bus.c:110: i

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-16 Thread Paolo Bonzini
- Original Message - > From: "Eduardo Habkost" > To: "Paolo Bonzini" > Cc: "Eduardo Otubo" , qemu-devel@nongnu.org, > qemu-triv...@nongnu.org, "Michael Tokarev" > , "Markus Armbruster" , "Alexander Graf" > > Sent: Saturday, September 16, 2017 12:21:13 AM > Subject: Re: [PATCH] dma/i8

Re: [Qemu-devel] [[PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-24 Thread Michael Tokarev
15.09.2017 12:06, Eduardo Otubo wrote: > QEMU fails when used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion > `!bus->dma[0] && !bus->dma[1]' failed. > Aborted

Re: [Qemu-devel] [[PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-25 Thread Paolo Bonzini
On 24/09/2017 23:02, Michael Tokarev wrote: > 15.09.2017 12:06, Eduardo Otubo wrote: >> QEMU fails when used with the following command line: >> >> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 >> qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion >> `

Re: [Qemu-devel] [[PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-25 Thread Eduardo Otubo
On Mon, Sep 25, 2017 at 11:11:37AM +0200, Paolo Bonzini wrote: > On 24/09/2017 23:02, Michael Tokarev wrote: > > 15.09.2017 12:06, Eduardo Otubo wrote: > >> QEMU fails when used with the following command line: > >> > >> ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device > >> i8

Re: [Qemu-devel] [[PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-25 Thread Paolo Bonzini
On 25/09/2017 11:26, Eduardo Otubo wrote: > On Mon, Sep 25, 2017 at 11:11:37AM +0200, Paolo Bonzini wrote: >> On 24/09/2017 23:02, Michael Tokarev wrote: >>> 15.09.2017 12:06, Eduardo Otubo wrote: QEMU fails when used with the following command line: ./ppc64-softmmu/qemu-system-ppc

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-25 Thread Michael Tokarev
25.09.2017 12:26, Eduardo Otubo wrote: > On Mon, Sep 25, 2017 at 11:11:37AM +0200, Paolo Bonzini wrote: >> On 24/09/2017 23:02, Michael Tokarev wrote: >>> 15.09.2017 12:06, Eduardo Otubo wrote: QEMU fails when used with the following command line: ./ppc64-softmmu/qemu-system-ppc64

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-25 Thread Paolo Bonzini
On 25/09/2017 12:54, Michael Tokarev wrote: >> Yes, that's correct. I can revert this patch with the error >> propagation patch as well, if you guys don't mind. > Hmm. After reading the original discussion I concluded this patch > is okay. I can remove it right now before the series has been > app

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-07 Thread Paolo Bonzini
Il 02 set 2017 11:17 AM, "Aurelien Jarno" ha scritto: On 2017-09-01 11:30, Eduardo Habkost wrote: > i82374 is compiled in only on ppc and sh4, so I'm CCing the > maintainers for those architectures. The i82374 device is not useful nor usable on SH4. It has just been added in commit 85d3846a39 to

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2018-03-26 Thread Thomas Huth
On 26.03.2018 13:18, Eduardo Otubo wrote: > QEMU fails when used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion > `!bus->dma[0] && !bus->dma[1]' failed. >

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2018-03-26 Thread Paolo Bonzini
On 26/03/2018 14:14, Thomas Huth wrote: >> +object_ref(OBJECT(dev)); >> +object_property_set_bool(OBJECT(dev), false, "realized", &err); >> +if (err) { >> +error_reportf_err(err, "Clean up of device %s failed: ", >> + object_get_typename(OBJECT(dev))); >

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2018-03-26 Thread Philippe Mathieu-Daudé
Hi Eduardo, On 03/26/2018 08:18 AM, Eduardo Otubo wrote: > QEMU fails when used with the following command line: > > ./ppc64-softmmu/qemu-system-ppc64 -S -machine 40p,accel=tcg -device i82374 > qemu-system-ppc64: hw/isa/isa-bus.c:110: isa_bus_dma: Assertion > `!bus->dma[0] && !bus->dma[1