Re: [Qemu-devel] [PATCH] doc/pcie: correct command line examples

2016-12-28 Thread Cao jin
On 12/28/2016 11:21 PM, Andrew Jones wrote: > On Wed, Dec 28, 2016 at 03:24:30PM +0200, Marcel Apfelbaum wrote: >> On 12/27/2016 09:40 AM, Cao jin wrote: >>> Nit picking: Multi-function PCI Express Root Ports should mean that >>> 'addr' property is mandatory, and slot is optional because it is de

Re: [Qemu-devel] [PATCH] doc/pcie: correct command line examples

2016-12-28 Thread Andrew Jones
On Wed, Dec 28, 2016 at 03:24:30PM +0200, Marcel Apfelbaum wrote: > On 12/27/2016 09:40 AM, Cao jin wrote: > > Nit picking: Multi-function PCI Express Root Ports should mean that > > 'addr' property is mandatory, and slot is optional because it is default > > to 0, and 'chassis' is mandatory for 2n

Re: [Qemu-devel] [PATCH] doc/pcie: correct command line examples

2016-12-28 Thread Marcel Apfelbaum
On 12/27/2016 09:40 AM, Cao jin wrote: Nit picking: Multi-function PCI Express Root Ports should mean that 'addr' property is mandatory, and slot is optional because it is default to 0, and 'chassis' is mandatory for 2nd & 3rd root port because it is default to 0 too. Bonus: fix a typo(2->3) Sig

[Qemu-devel] [PATCH] doc/pcie: correct command line examples

2016-12-26 Thread Cao jin
Nit picking: Multi-function PCI Express Root Ports should mean that 'addr' property is mandatory, and slot is optional because it is default to 0, and 'chassis' is mandatory for 2nd & 3rd root port because it is default to 0 too. Bonus: fix a typo(2->3) Signed-off-by: Cao jin --- docs/pcie.txt |